-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReadAsync length #17
Comments
Thanks for the code review. Yes, it really is worth it.
|
Had to tinker to find why this diagnostic didn't work: |
Fixed 030e9ba |
Already fixed! Nice 👍 It's surprising that the unused_value_assignment bug made is this far into the release cycle of VS2022. |
Hello,
First of all, this is a really nice project. I'm enjoying reading your code a lot, and this will definitely save me time so thanks. :)
While familiarizing myself with H.Pipes, I came across this bit in PipeStreamReader.cs
Shouldn't the return value (= number of bytes read) of ReadAsync be assigned and compared with the intended message length?
The text was updated successfully, but these errors were encountered: