Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GRPC clients management #1511

Closed
MichaelScofield opened this issue May 4, 2023 · 1 comment
Closed

Refactor GRPC clients management #1511

MichaelScofield opened this issue May 4, 2023 · 1 comment
Labels
A-frontend Involves code in the Frontend node C-enhancement Category Enhancements

Comments

@MichaelScofield
Copy link
Collaborator

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

Currently the GRPC clients management is a little chaos, there is ChannelManager for caching raw tonic channels, and there is DatanodeClients for managing Datanode GRPC clients for Frontend. This makes our codes hard to understand, and may introduce bugs hard to trace like memory leaks.

I think a redesign of our GRPC clients management is necessary, to alleviate the pain of debugging efforts.

Implementation challenges

No response

@MichaelScofield MichaelScofield added the C-enhancement Category Enhancements label May 4, 2023
@MichaelScofield MichaelScofield added the A-frontend Involves code in the Frontend node label Jun 7, 2023
@MichaelScofield
Copy link
Collaborator Author

too broad

@MichaelScofield MichaelScofield closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Involves code in the Frontend node C-enhancement Category Enhancements
Projects
None yet
Development

No branches or pull requests

1 participant