Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump com.google.cloud:libraries-bom from 26.22.0 to 26.23.0 #2166

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 15, 2023

Bumps com.google.cloud:libraries-bom from 26.22.0 to 26.23.0.

Release notes

Sourced from com.google.cloud:libraries-bom's releases.

v26.23.0

GCP Libraries BOM 26.23.0

Here are the differences from the previous version (26.22.0)

New Addition

  • com.google.cloud:google-cloud-infra-manager:0.1.0

The group ID of the following artifacts is com.google.cloud.

Notable Changes

google-cloud-bigquery 2.32.0 (prev: 2.31.1)

  • Add support for converting interval fields to threeten PeriodDuration (#2838) (2294c2f)
  • Add support for ExternalDatasetReference (#2871) (bbb86fd)

google-cloud-bigquerystorage 2.42.0 (prev: 2.41.1)

  • Add default_missing_value_interpretation field; indicate KMS_SERVICE_ERROR is retryable (#2229) (df686d6)

  • Expose settings to configure default missing value interpretation. (#2230) (dc5ed73)

  • Populate final stauts to initial request during connection shutdown (#2228) (9b9b5c0)

google-cloud-bigtable 2.27.2 (prev: 2.26.0)

  • Aggregate batching throttling latency per attempt and reset it between (#1905) (e6cc5f6)

  • Make sure to propagate the response when throttling is enabled (#1908) (f743187)

  • Check that all bulk mutation entries are accounted for (#1907) (9ad8a00)

  • Set wait timeout on watchdog (#1913) (f8ba6fe)

google-cloud-datastore 2.17.1 (prev: 2.16.3)

  • Publish proto definitions for SUM/AVG in Datastore (#1157) (954320a)
  • Sum and Avg aggregation feature (#1067) (56d1001)

google-cloud-pubsub 1.125.0 (prev: 1.124.1)

  • Update Publish retry backoff settings (#1686) (63a74d9)

  • Receipt modack (#1540) (74d8da9)

  • Make retry policy back off more aggressively for RPCs that retry RESOURCE_EXHAUSTD (#1704) (f61e7e0)

google-cloud-spanner 6.47.0 (prev: 6.45.0)

  • Adding support for databoost (#2505) (dd3e9a0)

  • Support PostgreSQL for autoConfigEmulator (#2601) (fbf1df9)

  • Fix kokoro windows java8 ci (#2573) (465df7b)

  • Add devcontainers for enabling github codespaces usage. (#2605) (a7d60f1)

  • Disable dynamic code loading properties by default (#2606) (d855ebb)

  • Add reflection configurations for com.google.rpc classes (#2617) (c42460a)

... (truncated)

Commits
  • c3b47c0 chore: release main (#6176)
  • 07fd615 deps: update actions/checkout action to v4 (#6183)
  • 73fa897 deps: update dependency com.google.cloud:google-cloud-pubsublite-bom to v1.12...
  • 2148a20 deps: update dependency com.google.cloud:first-party-dependencies to v3.15.0 ...
  • 6a3eee0 deps: update dependency com.google.cloud:gapic-libraries-bom to v1.18.0 (#6180)
  • b04dd62 deps: update dependency com.google.cloud:google-cloud-bigquery to v2.32.0 (#6...
  • f8c7aaf deps: update dependency com.google.cloud:google-cloud-bigquerystorage-bom to ...
  • 9581f46 deps: update dependency com.google.cloud:google-cloud-logging-bom to v3.15.9 ...
  • 2e950f0 deps: update dependency com.google.cloud:google-cloud-logging-logback to v0.1...
  • dba79e0 deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.47.0 ...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner September 15, 2023 04:28
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 15, 2023
@dependabot dependabot bot force-pushed the dependabot/maven/com.google.cloud-libraries-bom-26.23.0 branch 2 times, most recently from ad83fb3 to be464d1 Compare September 15, 2023 19:48
@mpeddada1
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/com.google.cloud-libraries-bom-26.23.0 branch from be464d1 to 0270a8d Compare September 15, 2023 23:07
@mpeddada1
Copy link
Contributor

Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project com.google.cloud:google-cloud-game-servers-spring-starter:4.7.3-SNAPSHOT-preview (/home/runner/work/spring-cloud-gcp/spring-cloud-gcp/spring-cloud-previews/google-cloud-game-servers-spring-starter/pom.xml) has 1 error
Error:      'dependencies.dependency.version' for com.google.cloud:google-cloud-game-servers:jar is missing. @ com.google.cloud:google-cloud-game-servers-spring-starter:${project.parent.version}-preview, /home/runner/work/spring-cloud-gcp/spring-cloud-gcp/spring-cloud-previews/google-cloud-game-servers-spring-starter/pom.xml, line 19, column 17

@meltsufin
Copy link
Member

@mpeddada1 Does our Spring CodeGen script handle library removal like in the case of game-servers?

@mpeddada1
Copy link
Contributor

@meltsufin the commit within the PR doesn't seem to get recognized by the script :

Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project com.google.cloud:google-cloud-game-servers-spring-starter:4.7.3-SNAPSHOT-preview (/home/runner/work/spring-cloud-gcp/spring-cloud-gcp/spring-cloud-previews/google-cloud-game-servers-spring-starter/pom.xml) has 1 error
Error:      'dependencies.dependency.version' for com.google.cloud:google-cloud-game-servers:jar is missing. @ com.google.cloud:google-cloud-game-servers-spring-starter:${project.parent.version}-preview, /home/runner/work/spring-cloud-gcp/spring-cloud-gcp/spring-cloud-previews/google-cloud-game-servers-spring-starter/pom.xml, line 19, column 17

I've created a separate PR to see if makes a difference: #2175

@mpeddada1
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 18, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@mpeddada1
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 18, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@mpeddada1
Copy link
Contributor

@dependabot recreate

Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.22.0 to 26.23.0.
- [Release notes](https://github.com/googleapis/java-cloud-bom/releases)
- [Changelog](https://github.com/googleapis/java-cloud-bom/blob/main/release-please-config.json)
- [Commits](googleapis/java-cloud-bom@v26.22.0...v26.23.0)

---
updated-dependencies:
- dependency-name: com.google.cloud:libraries-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/com.google.cloud-libraries-bom-26.23.0 branch from 5a42a8a to 86e765f Compare September 18, 2023 16:35
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mpeddada1
Copy link
Contributor

The Generate Spring Auto-Configuration job passes at Compile non auto-gen libraries stage by fails at generate libraries stage with:

+ mvn com.coveo:fmt-maven-plugin:format -Dfmt.skip=false
[INFO] Scanning for projects...
Error: ] Some problems were encountered while processing the POMs:
Error:  Child module /home/runner/work/spring-cloud-gcp/spring-cloud-gcp/spring-cloud-previews/1ca7973d74d2d16d610c1d8f252263dc5423bbfd-spring-starter of /home/runner/work/spring-cloud-gcp/spring-cloud-gcp/spring-cloud-previews/pom.xml does not exist @ 
Error:  Child module /home/runner/work/spring-cloud-gcp/spring-cloud-gcp/spring-cloud-previews/4.7.3-SNAPSHOT-spring-starter of /home/runner/work/spring-cloud-gcp/spring-cloud-gcp/spring-cloud-previews/pom.xml does not exist @ 

@suztomo
Copy link
Contributor

suztomo commented Sep 18, 2023

Are you able to reproduce the problem locally? Is the error message clear to you?

@mpeddada1
Copy link
Contributor

It looks it is complaining about the addition of 1ca7973d74d2d16d610c1d8f252263dc5423bbfd-spring-starter and 4.7.3-SNAPSHOT-spring-starter in the <modules></modules> section of spring-cloud-previews/pom.xml.

Running just mvn com.coveo:fmt-maven-plugin:format -Dfmt.skip=false locally on this PR and on main is successful but the lib generation job does some extra steps before calling this command. Looking.

@mpeddada1
Copy link
Contributor

mpeddada1 commented Sep 18, 2023

From the logs, the issue is specific to policytroubleshooter:

processing library google/cloud/policytroubleshooter/iam/v1
+ read -r library_name googleapis_location coordinates_version googleapis_commitish monorepo_folder
+ echo 'processing library google/cloud/policytroubleshooter/iam/v1'
++ echo 1ca7973d74d2d16d610c1d8f252263dc5423bbfd
++ cut -f1 -d:
+ group_id=1ca7973d74d2d16d610c1d8f252263dc5423bbfd
++ echo 1ca7973d74d2d16d610c1d8f252263dc5423bbfd
++ cut -f2 -d:
+ artifact_id=1ca7973d74d2d16d610c1d8f252263dc5423bbfd
+ tee tmp-output
+ postprocess_library 1ca7973d74d2d16d610c1d8f252263dc5423bbfd 1ca7973d74d2d16d610c1d8f252263dc5423bbfd 4.7.3-SNAPSHOT com.google.cloud:google-cloud-policy-troubleshooter java-policy-troubleshooter v1.18.0
+ client_lib_artifactid=1ca7973d74d2d16d610c1d8f252263dc5423bbfd
+ client_lib_groupid=1ca7973d74d2d16d610c1d8f252263dc5423bbfd
+ parent_version=4.7.3-SNAPSHOT
+ googleapis_folder=com.google.cloud:google-cloud-policy-troubleshooter
+ monorepo_folder=java-policy-troubleshooter
+ googleapis_commitish=v1.18.0
+ monorepo_commitish=
+ starter_artifactid=1ca7973d74d2d16d610c1d8f252263dc5423bbfd-spring-starter
++ cat googleapis/com.google.cloud:google-cloud-policy-troubleshooter/BUILD.bazel

^^ Note the starter_artifactid here

Also from the logs, contents of the library_list generated by the script show more # entries for policytroubleshooter:

oslogin, google/cloud/oslogin/v1, com.google.cloud:google-cloud-os-login, 7ac8a2479bd197e4d7533e1ae9bf1877823f0c26, java-os-login

policytroubleshooter, google/cloud/policytroubleshooter

google/cloud/policytroubleshooter/iam/v1, com.google.cloud:google-cloud-policy-troubleshooter, 1ca7973d74d2d16d610c1d8f252263dc5423bbfd, java-policy-troubleshooter

cloudprofiler, google/devtools/cloudprofiler/v2, com.google.cloud:google-cloud-profiler, 7ac8a2479bd197e4d7533e1ae9bf1877823f0c26, java-profiler

This line in the generate_library.sh script gets the googleapis_path from each module's Owlbot.yaml in google-cloud-java. Recently, google/cloud/policytroubleshooter/iam/ was added to
policytroubleshooter's Owlbot.yaml .

It is possible that the script caters for only one entry being in googleapis_path which results in variables being set to unrelated values when that is not the case.

@suztomo
Copy link
Contributor

suztomo commented Sep 19, 2023

These lines below seem strange

+ googleapis_commitish=v1.18.0
+ monorepo_commitish=

@diegomarquezp diegomarquezp merged commit a4050ec into main Sep 19, 2023
10 checks passed
@diegomarquezp diegomarquezp deleted the dependabot/maven/com.google.cloud-libraries-bom-26.23.0 branch September 19, 2023 14:22
@diegomarquezp diegomarquezp restored the dependabot/maven/com.google.cloud-libraries-bom-26.23.0 branch September 19, 2023 14:58
@diegomarquezp
Copy link
Contributor

Continued in #2183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants