Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add configuration for Cloud Run CLI flags #108

Closed
averikitsch opened this issue Nov 15, 2019 · 4 comments
Closed

[Feature Request] Add configuration for Cloud Run CLI flags #108

averikitsch opened this issue Nov 15, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@averikitsch
Copy link

Setting flags such as max instance and memory size from the configuration json.

@ahmetb
Copy link
Contributor

ahmetb commented Nov 15, 2019

Related: was discussed a bit here #89 (comment)

I think overall we need some property bag objects in app.json to control various aspects. Ideally, not a flat list, as that can result in gigantic objects over time as we add more flags to gcloud. So maybe some categorization of such objects can help.

@jamesward
Copy link
Contributor

Mem & cpu options are now available via app.json See: #175

@jamesward jamesward added enhancement New feature or request good first issue Good for newcomers labels Jun 1, 2020
@benwinding
Copy link

Would also be great to have the concurrency flag too if possible!

@glasnt
Copy link
Collaborator

glasnt commented Jun 19, 2022

Many flags were added in #228; there needs to be some thought as to how to make these flags easier to add in the future; maybe directly passing through to gcloud run deploy?

@glasnt glasnt closed this as completed Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants