Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo doesn't work #22

Closed
jespertheend opened this issue May 27, 2021 · 3 comments
Closed

Demo doesn't work #22

jespertheend opened this issue May 27, 2021 · 3 comments

Comments

@jespertheend
Copy link

When I run the steps at the bottom of readme.md and go to http:https://localhost:5000/demo/, the ripple effect doesn't work for any browser except for Chrome.
https://googlechromelabs.github.io/css-paint-polyfill/ still seems to be working in Safari and FireFox though.

@ntoniazzi
Copy link

I checked the different releases on Firefox 89. 3.1.0 works well, but not 3.1.1.
The change in maybeUpdateElement() broke it:
976f0f8#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556R489-R490

@jespertheend
Copy link
Author

Ah that explains why https://googlechromelabs.github.io/css-paint-polyfill/ is still working on Firefox. I guess it's using an old version.

@developit
Copy link
Collaborator

Fix released as 3.3.0 - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants