Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with --no-default-features #19

Open
chrysn opened this issue Mar 7, 2023 · 0 comments
Open

Build fails with --no-default-features #19

chrysn opened this issue Mar 7, 2023 · 0 comments

Comments

@chrysn
Copy link

chrysn commented Mar 7, 2023

Both in the released and the latest main version, building without the default combinators feature fails:

$ cargo check --no-default-features
[...]
error[E0432]: unresolved imports `crate::decoder::is_any`, `crate::decoder::CBORDecoder`
  --> tps_minicbor/src/encode.rs:32:22
   |
32 | use crate::decoder::{is_any, CBORDecoder, SequenceBuffer};
   |                      ^^^^^^  ^^^^^^^^^^^ no `CBORDecoder` in `decoder`
   |                      |
   |                      no `is_any` in `decoder`

It's not a big practical issue (I depended on default-features=false more out of habit, and need combinators anyway), but it's weird given that apparently some effort was spent on keeping them optional, but then it's never tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant