Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Missing icons cause panic #1156

Closed
3 of 10 tasks
pyrocto opened this issue Aug 12, 2021 · 1 comment
Closed
3 of 10 tasks

Missing icons cause panic #1156

pyrocto opened this issue Aug 12, 2021 · 1 comment
Labels
investigation Base triage label for bug reports.

Comments

@pyrocto
Copy link
Contributor

pyrocto commented Aug 12, 2021

Technical information

Using version:

  • master (running from GitHub-published source code, currently v2.2.8-pre)
  • latest (latest release, currently v2.2.7)
  • vX.X.X (specify other version)

Running on:

  • Linux
  • Windows
  • macOS

How comfortable you are with your system and/or IT in general:

  • I'm kind of lost, honestly
  • I know what's up, I could help you run some commands or checks
  • My machine is fully under my control, tell me what you need
  • I attended Defcon last year

Problem

There are a few problems being caused by missing icons. First, the missing audio icon means that mp3s and so forth merely show up as unknown files. Second, the HTML templates for the audio player and the PDF renderer and so on all cause panics because of the missing icons for the controls.

The list of icons is missing at least audio, zoomin, zoomout, arrowback, arrownext, playarrow, volumeup, and fullscreen.

These icons seem like reasonable replacements if the original source is now missing.
https://github.com/danklammer/bytesize-icons

@pyrocto pyrocto added the investigation Base triage label for bug reports. label Aug 12, 2021
@15279797616
Copy link

Technical information

Using version:

  • master (running from GitHub-published source code, currently v2.2.8-pre)
  • latest (latest release, currently v2.2.7)
  • vX.X.X (specify other version)

Running on:

  • Linux
  • Windows
  • macOS

How comfortable you are with your system and/or IT in general:

  • I'm kind of lost, honestly
  • I know what's up, I could help you run some commands or checks
  • My machine is fully under my control, tell me what you need
  • I attended Defcon last year

Problem

There are a few problems being caused by missing icons. First, the missing audio icon means that mp3s and so forth merely show up as unknown files. Second, the HTML templates for the audio player and the PDF renderer and so on all cause panics because of the missing icons for the controls.

The list of icons is missing at least audio, zoomin, zoomout, arrowback, arrownext, playarrow, volumeup, and fullscreen.

These icons seem like reasonable replacements if the original source is now missing.
https://github.com/danklammer/bytesize-icons

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
investigation Base triage label for bug reports.
Projects
None yet
Development

No branches or pull requests

2 participants