Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.13] Addition of Status & Environment to list of possible values #769

Merged
merged 10 commits into from
Dec 3, 2023
Merged

[11.13] Addition of Status & Environment to list of possible values #769

merged 10 commits into from
Dec 3, 2023

Conversation

donkidd
Copy link
Contributor

@donkidd donkidd commented Aug 11, 2023

Added Status an Environment as parameters that can be sent to deployment method. This is to fix #768

GrahamCampbell
GrahamCampbell requested changes Oct 8, 2023
View reviewed changes
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've left notes inline to be addressed before merge.

src/Api/Deployments.php Show resolved Hide resolved
@GrahamCampbell GrahamCampbell changed the title Addition of Status & Environment to list of possible values [11.13] Addition of Status & Environment to list of possible values Oct 8, 2023
@GrahamCampbell GrahamCampbell changed the base branch from 11.11 to 11.13 October 8, 2023 14:09
@GrahamCampbell
Copy link
Member

GrahamCampbell commented Oct 8, 2023 •
edited
Loading

r.e. StyleCI, it gives you the diff with the fixes to download and then apply using git, so you don't have to take multiple tries. ;)

image

https://github.styleci.io/analyses/YOdYGj/diff

@GrahamCampbell
Copy link
Member

Thanks.

@GrahamCampbell GrahamCampbell merged commit b3244ef into GitLabPHP:11.13 Dec 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for additional filters in the Deployment API
2 participants
@donkidd @GrahamCampbell