[11.6] Add support for protected tags #679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Lockett <[email protected]>
20uf
approved these changes
Dec 8, 2021
GrahamCampbell
requested changes
Dec 26, 2021
|
|
||
| /** | ||
| * @param int|string $project_id | ||
| * @param array $parameters |
There was a problem hiding this comment.
I cannot merge this with arbitrary undocumented parameters. Please either delete the parameter, or document those that are permitted, enforced with the options resolver.
There was a problem hiding this comment.
I copied how the protectedBranches method was implemented. Is there some extra documentation somewhere that I missed, that I should add to?
|
|
||
| /** | ||
| * @param int|string $project_id | ||
| * @param array $parameters |
GrahamCampbell
changed the title
|
Closing due to inactivity and merge conflicts. Please feel free to send in a new PR if you'd still like for this change to be made. |
|
Actually I was waiting on a reply to my question here #679 (comment). I'm no longer using this library so I'm happy for this PR to stay closed though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some missing endpoints regarding protected tags.
Closes #678.