Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8 #604

Closed
arokettu opened this issue Nov 24, 2020 · 3 comments
Closed

Support PHP 8 #604

arokettu opened this issue Nov 24, 2020 · 3 comments

Comments

@arokettu
Copy link

PHP 8 is released this Thursday. Please add support.

Tests seem to pass so apparently only the declaration in composer is required
@andypost
Copy link

Tests also needs fixes after matrix extended https://github.com/GitLabPHP/Client/blob/10.2/.github/workflows/tests.yml#L14

@GrahamCampbell
Copy link
Member

Support for PHP 8 was blocked on our dependencies. I have made fixes in those over the last few months, and as of a week ago, or so, they are now ready. I will get around to adding PHP 8 here soon.

@GrahamCampbell
Copy link
Member

Version 10.3.0 is out now, with support for PHP 8. Similarly, graham-campbell/gitlab version 4.3.0 is out too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andypost @arokettu @GrahamCampbell