-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gush is integrating this library #32
Comments
Hey, It should be very easy to change the HTTP client to support Guzzle, I had always planned to decouple from Buzz but just haven't had the time to do it. All you would need to do is implement the HttpClientInterface to integrate with Guzzle. |
nice, you rock'n man |
/cc @cordoval @jubianchi Hey guys, whats happening with this? |
is this ticket to remove buzz dependency and plug guzzle 4? |
Gush adapter already integrates this library, so we use it in the gitlab adapter https://github.com/gushphp/gush-gitlab-adapter/blob/master/composer.json#L5 of course that * is wrong and it should rather be the latest version and we should push you to tag bugfixes with the 3rd number on semver tag. |
I will close and reopen ticket with the right name |
I have heard complaints that this library does not use guzzle3 or 4.
It seems like is the only library around for gitlab that is more downloaded so far in packagist.
This ticket is to reference https://github.com/gushphp/gush-gitlab-adapter/blob/master/src/Adapter/GitLabAdapter.php#L86 and also asking for help integrating your library in.
We will first make it work then proceed to rewrite so it will use guzzle4 maybe.
Encouragements and thanks, feel welcome to contribute to Gush and join the core team 👶
The text was updated successfully, but these errors were encountered: