Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSK-1895 New worker pool #1478

Merged
merged 26 commits into from
Oct 25, 2023
Merged

GSK-1895 New worker pool #1478

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
18565be
Creating new worker pool
Hartorn Oct 13, 2023
9af63c7
Trying new worker pool
Hartorn Oct 13, 2023
f5a35fd
Improve worker clean up
Hartorn Oct 13, 2023
788f9f4
Try to fix tests for CI
Hartorn Oct 13, 2023
8dc5601
Removing git dependency
Hartorn Oct 16, 2023
d9a853e
Repair tests with multiprocess (issue with coverage)
Hartorn Oct 16, 2023
4e126eb
Adding logs capture in worker pool
Hartorn Oct 16, 2023
9c116e2
Fix lock file
Hartorn Oct 20, 2023
dfd6d1b
Improve threads + taking in account review
Hartorn Oct 20, 2023
65af850
Making process manipulation safer
Hartorn Oct 20, 2023
28d8b47
Adding some more logs and warm up at start for the worker
Hartorn Oct 20, 2023
82057d7
Improve code quality
Hartorn Oct 22, 2023
62c72c4
Marking analytics thread as daemon
Hartorn Oct 23, 2023
a873dae
Minor cleaning
Hartorn Oct 23, 2023
b93067b
Improving forced shutdown
Hartorn Oct 23, 2023
c53635d
Re-working process worker
Hartorn Oct 23, 2023
331b11e
Making safe_get safer
Hartorn Oct 23, 2023
91cb65d
Merge branch 'main' into new-worker-pool
Inokinoki Oct 24, 2023
c50be07
Comment code
Hartorn Oct 24, 2023
626f69e
Skipping tests for windows
Hartorn Oct 24, 2023
25eb2b9
Merge branch 'main' into new-worker-pool
Hartorn Oct 24, 2023
8c04bfd
Merge branch 'main' into new-worker-pool
Hartorn Oct 25, 2023
cfebc73
Merge branch 'main' into new-worker-pool
andreybavt Oct 25, 2023
cc630bf
update lockfile
andreybavt Oct 25, 2023
f4eb8bf
update lockfile
andreybavt Oct 25, 2023
1e6cc6e
fix build
andreybavt Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Marking analytics thread as daemon
  • Loading branch information
@Hartorn
Hartorn committed Oct 23, 2023
commit 62c72c465f5b8feb3dec2b528edbd1744acb439c
2 changes: 1 addition & 1 deletion giskard/utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

def threaded(fn):
def wrapper(*args, **kwargs):
thread = Thread(target=fn, args=args, kwargs=kwargs)
thread = Thread(target=fn, daemon=True, args=args, kwargs=kwargs)
thread.start()
return thread

Expand Down
Loading