Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK-1770] Fix text explanation for regression model #1475

Conversation

Inokinoki
Copy link
Member

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Oct 11, 2023

GSK-1770 model explanation is breaking for hotel text regression on demo instance

Sep 20 13:58:21 ns3031812 python[418761]: 2023-09-20 13:58:21,240 pid:418761 Thread-4349 (dispatch_action) giskard.ml_worker.utils.logging INFO     giskard.models.model_explanation.explain_text executed in 0:00:00.673506
Sep 20 13:58:21 ns3031812 python[418761]: 2023-09-20 13:58:21,241 pid:418761 Thread-4349 (dispatch_action) giskard.ml_worker.websocket.listener WARNING  'NoneType' object is not iterable
Sep 20 13:58:39 ns3031812 python[418761]: 2023-09-20 13:58:39,082 pid:418761 Thread-4359 (dispatch_action) giskard.client.giskard_client INFO     Artifact hotel_text_regression/models/497aabdc-61e6-4c27-bcfc-0c7379745ab7 already exists, skipping download
Sep 20 13:58:39 ns3031812 python[418761]: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.
Sep 20 13:58:39 ns3031812 python[418761]: 2023-09-20 13:58:39,373 pid:418761 Thread-4359 (dispatch_action) giskard.ml_worker.utils.logging INFO     giskard.models.model_explanation.explain_text executed in 0:00:00.270094
Sep 20 13:58:39 ns3031812 python[418761]: 2023-09-20 13:58:39,373 pid:418761 Thread-4359 (dispatch_action) giskard.ml_worker.websocket.listener WARNING  'NoneType' object is not iterable

Screenshot 2023-09-20 at 2.51.14 PM.png

@Hartorn Hartorn force-pushed the fix/gsk-1770-model-explanation-is-breaking-for-hotel-text-regression-on branch from 9652350 to 93d94c7 Compare October 11, 2023 08:04
@Inokinoki
Copy link
Member Author

@AbSsEnT does this resolve our problem? Or should we find a better solution for the general case?

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Hartorn Hartorn merged commit 070ccc5 into main Oct 12, 2023
13 checks passed
@Hartorn Hartorn deleted the fix/gsk-1770-model-explanation-is-breaking-for-hotel-text-regression-on branch October 12, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants