Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model upload unit-tests for pre-2.0.0 API #376

Closed
wants to merge 49 commits into from
Closed

model upload unit-tests for pre-2.0.0 API #376

wants to merge 49 commits into from

Conversation

rabah-khalek
Copy link
Member

@rabah-khalek rabah-khalek commented Nov 29, 2022 •
edited by andreybavt
Loading

@gitguardian
Copy link

gitguardian bot commented Nov 29, 2022 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@rabah-khalek rabah-khalek changed the title G 336 model api GSK-336/task model API Nov 29, 2022
@rabah-khalek rabah-khalek marked this pull request as draft November 30, 2022 11:46
@andreybavt andreybavt added this to the 1.4.0 milestone Dec 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rabah-khalek rabah-khalek mentioned this pull request Dec 19, 2022
Closed
@rabah-khalek rabah-khalek linked an issue Dec 19, 2022 that may be closed by this pull request
Class based model upload #384
Closed
@rabah-khalek rabah-khalek marked this pull request as ready for review February 1, 2023 17:12
@rabah-khalek rabah-khalek changed the title New model upload API tests model upload unit-tests for pre-2.0.0 API Feb 1, 2023
@rabah-khalek rabah-khalek removed wip new-upload-api Class based model and dataset upload API labels Feb 1, 2023
@andreybavt
Copy link
Collaborator

@rabah-khalek, have you copied all of the tests from this branch to the *-tensorflow and *-pytorch branches? Should we close this PR?

@rabah-khalek
Copy link
Member Author

Yes i took what i needed. But can't we merge this one and mark the failing unit tests skipped? Just for bookkeeping.

@andreybavt
Copy link
Collaborator

@rabah-khalek , it'll at least require the test files refactoring to make them PEP8 compatible. If you're saying that everything is copied to other branches we can close this PR then

@rabah-khalek
Copy link
Member Author

ok done.

@rabah-khalek
Copy link
Member Author

for some reason that I'm still investigating, one of these libraries: h2o torch transformers tensorflow torchtext torchdata is causing test_upload.py to fail.

@rabah-khalek rabah-khalek marked this pull request as draft March 4, 2023 12:44
@andreybavt
Copy link
Collaborator

@rabah-khalek , do we close this PR?

@rabah-khalek
Copy link
Member Author

Yes.

@Hartorn Hartorn deleted the GSK-336_model-API branch September 22, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreybavt andreybavt Awaiting requested review from andreybavt

Assignees

@andreybavt andreybavt

@rabah-khalek rabah-khalek

Labels
on hold
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Class based model upload
2 participants
@rabah-khalek @andreybavt