Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File not found #273

Closed
p4puniya opened this issue Sep 27, 2022 · 5 comments
Closed

File not found #273

p4puniya opened this issue Sep 27, 2022 · 5 comments

Comments

@p4puniya
Copy link
Contributor

p4puniya commented Sep 27, 2022

The PFA file Worker is not found. And the said folder contains various errors when opened in my IDE.

Screenshot from 2022-09-27 23-23-11

@p4puniya
Copy link
Contributor Author

I guess the said file is either removed or moved to a new destination. If possible can someone guide me on how to resolve this issue? I'm just starting with open-source so please bear with me.😅

@andreybavt
Copy link
Contributor

Hi @p4puniya ,
The missing files are auto-generated during the build of the project. To run the build you can execute ./gradlew build from the root of the cloned repo.

We're working on improving developers' documentation, for now, there's a Notion page that describes how to set up Giskard for local development using Intellij Idea (but you may find it useful for VS Code too).
https://giskard.notion.site/Running-Giskard-on-local-without-docker-6b5b4f47a0da4b4a9851bbf65199c5cd

@p4puniya
Copy link
Contributor Author

Hi @andreybavt ,
I tried building the project but it shows APPLICATION FAILED TO START
Here's the description and the action:
Description:
Parameter 2 of constructor in ai.giskard.service.ProjectService required a bean of type 'ai.giskard.web.dto.mapper.GiskardMapper' that could not be found.
Action:
Consider defining a bean of type 'ai.giskard.web.dto.mapper.GiskardMapper' in your configuration.

@olla-dev
Copy link

olla-dev commented Nov 18, 2022

Hello @p4puniya,

Reposting this here from discussion on discord (thanks for the help).

This should solve your problem:

classes from ai.giskard.worker are autogenerated from GRPC proto file located in giskard-server/ml-worker-proto/proto/ml-worker.proto

This ml-worker-proto directory is a submodule, so to fetch it you can run this command from the root of giskard repository
git submodule update --init --recursive -q

next, to generate the missing java files you can run
./gradlew :giskard-server:cleanGenerated :giskard-server:generateProto

@andreybavt
Copy link
Contributor

Hi everyone,

We decided to simplify Giskard repo structure and merged 3 repos (giskard, giskard-client, and ml-worker-proto) into the main giskard repo. This allowed us to get rid of the proto file submodule, so no need to pull submodule recursively now.

Starting giskard in dev mode should be now done with just

./gradlew start --parallel

Check out the dev readme for more details
https://github.com/Giskard-AI/giskard/blob/main/README.dev.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants