Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support to finding retesting, custom enums to findings and Status #242

Closed
pimps opened this issue Aug 30, 2022 · 10 comments
Labels

Comments

@pimps
Copy link

pimps commented Aug 30, 2022

Is your feature request related to a problem? Please describe.
The app doesn't support retesting at the moment. Also, the finding status is only used for keeping status of finding writing with "requires editing" and "ready".

Describe the solution you'd like

  • Add more status to the finding like "Open", "Fixed/Closed", "Risk Accepted".
  • Add another rich text field on the finding for retesting notes.
  • Add the ability to insert custom enums in the finding templates and/or custom rich text fields. For example, the ability to add Likelihood and Technical Impact (That are basically enums). This is useful for teams that use custom score rating instead of CVSS. Adding the ability to insert custom rich text fields in the report would likely make the tool capable to handle any kind of scenario related to templating.

Describe alternatives you've considered
Unfortunately there is no alternatives to use to cover this request.

Additional context
Teams usually needs to perform retesting on findings. Adding support to this in ghostwriter would be awesome. Additionally, adding the ability to include custom enums and rich text fields to findings in an easy way would help teams to easily adapt templating.

@Cave-Johnson
Copy link

I'd like to +1 this. Especially the ability to use rating / scoring methods other than CVSS and severity.

@cccaaasser
Copy link

I like this finding tracking idea.

@KomodoGal
Copy link

+1 to both, especially the custom enums

@KomodoGal
Copy link

I found a work around, in my case we use "Severity", "Impact" and "Probability", I was able to insert "Impact" and "Probability" in the "CVSS vector" field like this: High;Low (Impact;Probability) then in the template I separate them and through a bunch of if statements you can get formatted text:

Impact: {% set im = finding.cvss_vector.split(‘;’)[0] %}{% if ‘Cri’ in im %}Critical{% elif ‘High’ in im %}High{% elif ‘Med’ in im %}Medium{% elif ‘Low’ in im %}Low{% else %}Informational{% endif %}
Probability: {% set pr = finding.cvss_vector.split(‘;’)[-1] %}{% if ‘Cri’ in pr %}Critical{% elif ‘High’ in pr %}High{% elif ‘Med’ in pr %}Medium{% elif ‘Low’ in pr %}Low{% else %}Informational{% endif %}

(All the strings between the if statements are formatted to your liking)
I was not able to insert more than 3 fields into the CVSS vector field. Every time I would try to reference a higher index the template will fail. You can use pop(0) to get another field

@chrismaddalena
Copy link
Collaborator

Thanks for sharing!

@ArgentEnergy
Copy link

ArgentEnergy commented Jan 18, 2023

+1 for having custom fields.

My work is currently using host_detection as a finding category (Input Validation, Authentication, etc...), network_techniques for difficulty of exploit (Low, Medium, and High), replication_steps as finding status (OPEN, CLOSED, ACCEPTED), and affected_entities as our finding evidence.

Right now we have to manually update an executive summary page and retest notes for findings.

Another couple features not mentioned here that would be nice:

  • Easier way to integrate chart generation
  • A new page that allows users to search for report findings by different criteria (date, evidence text, tester that found the finding, finding title). For example, show me all high and critical findings with the text containing "SAML tampering" found by Bob in 2022.

We use pandas with matplotlib to generate custom charts that are then embedded in the report automatically from Ghostwriter. I had to modify the reportwriter.py and a few other files in the core code for the chart integration.

@chrismaddalena For reference: master...StratumSecurity:Ghostwriter:v3.1.5-custom

@chrismaddalena
Copy link
Collaborator

Thanks for sharing your work, @ArgentEnergy!

@MoJo1760
Copy link

+1 for a remediation testing flag

Copy link

This issue has been labeled as stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jun 21, 2024
Copy link

github-actions bot commented Jul 5, 2024

This issue is closed because it has been inactive for 14 days since being labeled stale. Feel free to re-open the issue with a comment. If this needs further discussion (e.g., a feature request), it might be better to open a topic under the Discussions tab.

@github-actions github-actions bot closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants