Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how PyGMT loads the GMT library #867

Closed
seisman opened this issue Feb 12, 2021 · 0 comments · Fixed by #2930
Closed

Improve how PyGMT loads the GMT library #867

seisman opened this issue Feb 12, 2021 · 0 comments · Fixed by #2930
Labels
enhancement Improving an existing feature
Milestone

Comments

@seisman
Copy link
Member

seisman commented Feb 12, 2021

A few thoughts on the design of loading the library as a whole (might be out of scope for this PR but worth mentioning):

  • I initially made the Session class load the library when it's used to avoid doing this work at import time. Mostly so we wouldn't have GMTLibNotFoundError at import.
  • That clearly didn't work because we need to call begin at import for this whole thing to work.
  • So it might be time to rethink loading libgmt in the class instead of as a global instead to avoid searching for it every time.
  • Or we figure out a way to not call begin at import time.

Originally posted by @leouieda in #702 (comment)

@seisman seisman added the enhancement Improving an existing feature label Feb 12, 2021
@weiji14 weiji14 mentioned this issue Apr 27, 2021
3 tasks
@weiji14 weiji14 added the help wanted Helping hands are appreciated label Nov 8, 2021
@weiji14 weiji14 added this to the 1.0.0 milestone Nov 8, 2021
@weiji14 weiji14 modified the milestones: 1.0.0, 0.11.0 Jan 2, 2024
@seisman seisman removed the help wanted Helping hands are appreciated label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants