Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure surface and grdcut loads GMTDataArray accessor info into xarray #539

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jul 21, 2020

Description of proposed changes

For modules like surface and grdcut that output an xarray.DataArray grid, we need to ensure that the registration and gtype information is loaded properly into the xarray.DataArray before the temporary netcdf file gets deleted.

Fixes #524

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

For modules like `surface` and `grdcut` that output an xarray.DataArray grid, we need to ensure that the registration and gtype information is loaded properly into the xarray.DataArray before the temporary netcdf file gets deleted.
@weiji14 weiji14 added the bug Something isn't working label Jul 21, 2020
@weiji14 weiji14 added this to the 0.2.x milestone Jul 21, 2020
@weiji14 weiji14 merged commit 87e7d42 into master Jul 21, 2020
@weiji14 weiji14 deleted the load_gmtaccessor_info branch July 21, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GMTDataArrayAccessor doesn't work for temporary files that have been sliced
2 participants