Quickfix min elevation for new SRTM15+V2.1 earth relief grids #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream GMT has updated its earth relief grids to SRTM15+V2.1 to fill in NaN values (see GenericMappingTools/gmt#2920). This commit fixes the test failures due to incorrect minimum elevation values, and minor changes to the contour and grid plots.
|
Cool, how do you bypass the required check in #397 to merge in the PR? The 'Squash and Merge' button is grayed out for me. |
|
It's also gray to me due to the strict branch protection rules. I had to go to "Settings"->"Branches" and change the rules temporarily to allow me merging that PR. |
|
Owh ok, that's annoying. I'll try that... |
|
Cool, I've temporarily disabled the |
weiji14
referenced
this pull request
in weiji14/pygmt
Mar 26, 2020
Refresh baseline plots to use SRTM15+V2.1 grids as per #401. Ran `pytest --mpl-generate-path=baseline pygmt/tests/test_grdview.py` to generate the png images.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Upstream GMT has updated its earth relief grids to SRTM15+V2.1 to fill in NaN values (see GenericMappingTools/gmt#2920). This commit fixes the test failures due to incorrect minimum elevation values, and minor changes to the contour and grid plots.
Supersedes #350
Manually changed the doctests in the
pygmt/clib/session.pyfile, and the tests in thetest_datasets.pyandtest_info.pyfiles. Plus ran the below two commands to generate new baseline images:Fixes #399
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.