Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy typo fix] #dropthedot from py.test #336

Closed
weiji14 opened this issue Oct 9, 2019 · 1 comment · Fixed by #338
Closed

[Easy typo fix] #dropthedot from py.test #336

weiji14 opened this issue Oct 9, 2019 · 1 comment · Fixed by #338
Labels
first-timers-only For absolute beginners good first issue Good for newcomers hacktoberfest Hacking away in the month of October

Comments

@weiji14
Copy link
Member

weiji14 commented Oct 9, 2019

Description of the problem

First-timers 1️⃣ only!! This should be about as simple as it gets. You'll literally be removing just a dot . from py.test in the Testing plots section in CONTRIBUTING.md.

In other words, change:

py.test --mpl-generate-path=baseline pygmt/tests/NAME_OF_TEST_FILE.py

to

pytest --mpl-generate-path=baseline pygmt/tests/NAME_OF_TEST_FILE.py

You can edit the file online on Github :octocat: here or in your Text Editor or Integrated Development Environment (IDE).

For some background on why we've decided to #dropthedot, see https://stackoverflow.com/questions/39495429/py-test-vs-pytest-command and https://twitter.com/davehunt82/status/756080181085872129. Basically it's because py.test will be go away/be deprecated at some point in the future.

How to get help

You can check out our CONTRIBUTING.md file (that's the file you'll be fixing by the way!) or this website https://firstcontributions.github.io/ on how to make your first contribution. Leave a comment below if you'd like to start working on this and feel free to ask for help! It's actually as much of a learning experience for us (guiding new people) as it will be for you 😄

Stretch goals

There's actually another place in the repository that refers to py.test instead of pytest. Can you find it and fix that too?

@weiji14 weiji14 added good first issue Good for newcomers hacktoberfest Hacking away in the month of October first-timers-only For absolute beginners labels Oct 9, 2019
@Dovacody
Copy link
Contributor

Dovacody commented Oct 9, 2019

Hello, I just submitted a pull request that fixed this typo. Thank you for posting something to help us new to all of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only For absolute beginners good first issue Good for newcomers hacktoberfest Hacking away in the month of October
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants