Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: grdhisteq.compute_bins: use int64 dtype for bin_id column instead of uint32 #3294

Closed
wants to merge 1 commit into from

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jun 19, 2024

Description of proposed changes

Change to follow the pandas 3.0 default RangeIndex column's dtype.

For context, the uint32 dtype was originally set in the initial implementation of grdhisteq.compute_bins at #1433 (comment).

Fixes #3291

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

Change to follow the pandas 3.0 default RangeIndex column's dtype.
@weiji14 weiji14 added bug Something isn't working run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR labels Jun 19, 2024
@weiji14 weiji14 added this to the 0.13.0 milestone Jun 19, 2024
@weiji14 weiji14 self-assigned this Jun 19, 2024
@weiji14
Copy link
Member Author

weiji14 commented Jun 19, 2024

This is just a proof of concept if going with int64 dtype. Personally, I'd still prefer it if we can stick with uint32, but this might require a bug fix upstream in pandas.

@weiji14
Copy link
Member Author

weiji14 commented Jun 19, 2024

Closing in favor of #3295.

@weiji14 weiji14 closed this Jun 19, 2024
@weiji14 weiji14 deleted the fix/bin_id_dtype branch June 19, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One test fails with pandas 3.0 dev version
1 participant