Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the list of cache files used in CI #3144

Closed
seisman opened this issue Mar 27, 2024 · 1 comment · Fixed by #3171
Closed

Reorganize the list of cache files used in CI #3144

seisman opened this issue Mar 27, 2024 · 1 comment · Fixed by #3171
Labels
maintenance Boring but important stuff for the core devs
Milestone

Comments

@seisman
Copy link
Member

seisman commented Mar 27, 2024

Many remote files are cached as GitHub Actions assets to be reused in CI workflows. These files are listed in the pygmt/helpers/caching.py file. See below:

datasets = [
# Earth relief grids
"@earth_gebco_01d_g",
"@earth_gebcosi_01d_g",
"@earth_gebcosi_15m_p",
"@earth_relief_01d_p",
"@earth_relief_01d_g",
"@earth_relief_30m_p",

Currently, the list is a little messy. Some potential improvements:

  1. Put some comments (e.g., "Names like @N35E135.earth_relief_03s_g.nc are for internal use only.") at the start of the list.
  2. Remove some comments like "# Specific grid for 15s test"
  3. Update the order of some entries. First categorize files into groups and sort alphabetically in each group.

Helps are welcome.

@seisman seisman added good first issue Good for newcomers help wanted Helping hands are appreciated labels Mar 27, 2024
Copy link

welcome bot commented Mar 27, 2024

👋 Thanks for opening your first issue here! Please make sure you filled out the template with as much detail as possible. You might also want to take a look at our contributing guidelines and code of conduct.

@seisman seisman added this to the 0.12.0 milestone Apr 15, 2024
@seisman seisman added maintenance Boring but important stuff for the core devs and removed good first issue Good for newcomers help wanted Helping hands are appreciated labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant