Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sphinx<=1.8.5 temporarily to avoid style errors introduced in sphinx 2.x #306

Merged
merged 2 commits into from
May 3, 2019
Merged

Use sphinx<=1.8.5 temporarily to avoid style errors introduced in sphinx 2.x #306

merged 2 commits into from
May 3, 2019

Conversation

seisman
Copy link
Member

@seisman seisman commented May 3, 2019

Description of proposed changes
Use sphinx<=1.8.5.

Fixes #305.

@seisman seisman requested a review from leouieda May 3, 2019 20:06
leouieda
leouieda approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @seisman. I added the restriction to the conda environment as well. Will merge as soon as CIs are happy.

@leouieda leouieda merged commit 997b88c into master May 3, 2019
@leouieda leouieda deleted the fix-sphinx-version branch May 3, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leouieda leouieda leouieda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API documentations generated by sphinx 2.x are unreadable
2 participants
@seisman @leouieda