Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load_* functions to support more remote relief datasets #2431

Open
5 of 11 tasks
seisman opened this issue Mar 16, 2023 · 11 comments
Open
5 of 11 tasks

Add load_* functions to support more remote relief datasets #2431

seisman opened this issue Mar 16, 2023 · 11 comments
Labels
feature request New feature wanted help wanted Helping hands are appreciated

Comments

@seisman
Copy link
Member

seisman commented Mar 16, 2023

Description of the desired feature

The GMT side is working on the lunar relief dataset for remote use and it's close to being finished (GenericMappingTools/gmtserver-admin#167). Similar to other load_earth_* functions (xref #1786), we need to add a load_moon_relief function to download and load the data.

@seisman seisman added the feature request New feature wanted label Mar 16, 2023
@michaelgrund
Copy link
Member

Would like to work on this if the GMT-side implementation is done!

@Esteban82
Copy link
Member

Not just the Moon. Also Mercury, Venus, Mars and Pluto.

@seisman seisman changed the title Add load_moon_relief function to load remote lunar relief dataset Add load_* functions to support more remote relief datasets Mar 19, 2023
@seisman
Copy link
Member Author

seisman commented Mar 19, 2023

Not just the Moon. Also Mercury, Venus, Mars and Pluto.

Thanks, I've updated the PR title.

@seisman
Copy link
Member Author

seisman commented Sep 9, 2023

As shown in GenericMappingTools/gmtserver-admin#219, the building of the planetary relief datasets is almost finished. These new datasets are still not available on the GMT main server but are available on the candidate server (http:https://candidate.generic-mapping-tools.org/server/).

I think @PaulWessel decided to release these new datasets at the same time as the GMT 6.5 release, which may happen shortly (maybe in a few weeks).

It would be great if we could add load_* function to support these new datasets. When the new datasets are released with GMT 6.5, we can add the following sentence to the announcement:

You may also want to try the latest PyGMT dev version, which already provides the load_xxx_relief functions to help you load these new datasets as xarray.DataArray.

We can also decide if these new functions are worth a new PyGMT release, i.e., releasing GMT 6.5, the new datasets, and PyGMT v0.11.0 at the same day, although PyGMT v 0.10.0 was released only a few days ago.

@Esteban82
Copy link
Member

I think @PaulWessel decided to release these new datasets at the same time as the GMT 6.5 release, which may happen shortly (maybe in a few weeks).

Most likely, because in order to access the highest resolution of the some planets a new GMT version is needed (see GenericMappingTools/gmtserver-admin#171 (comment)). Maybe will you have the same issue?

@seisman
Copy link
Member Author

seisman commented Sep 9, 2023

I think @PaulWessel decided to release these new datasets at the same time as the GMT 6.5 release, which may happen shortly (maybe in a few weeks).

Most likely, because in order to access the highest resolution of the some planets a new GMT version is needed (see GenericMappingTools/gmtserver-admin#171 (comment)). Maybe will you have the same issue?

Didn't realize the issue yet. Will read and see what happens.

@weiji14
Copy link
Member

weiji14 commented Sep 9, 2023

We can also decide if these new functions are worth a new PyGMT release, i.e., releasing GMT 6.5, the new datasets, and PyGMT v0.11.0 at the same day, although PyGMT v 0.10.0 was released only a few days ago.

Probably just need a patch release (v0.10.1) to support GMT 6.5? Depends on how backward incompatible things are. It sounds like most other functions should still be ok, just the remote datasets are affected.

@seisman
Copy link
Member Author

seisman commented Sep 12, 2023

Depends on how backward incompatible things are. It sounds like most other functions should still be ok, just the remote datasets are affected.

See GenericMappingTools/gmtserver-admin#171 for more discussions if you're interested. As far as I can see, there are no backward incompatibilities between 6.4 and 6.5. GMT 6.4 can access all these new remote datasets except a few full-resolution grids (e.g., pluto grid with a 52.0732883317s increment), while GMT 6.5 can.

Probably just need a patch release (v0.10.1) to support GMT 6.5?

The point is to provide more load functions (e.g., load_moon_relief in PR #2674) to load the new datasets into xarray.DataArray object. These are new features and should be included in v0.11.0. The question is, do we want to release v0.11.0 in Jan, 2024 following our quarterly release policy, or release earlier, on the same day as GMT 6.5.

@weiji14
Copy link
Member

weiji14 commented Sep 19, 2023

The question is, do we want to release v0.11.0 in Jan, 2024 following our quarterly release policy, or release earlier, on the same day as GMT 6.5.

When is the planned release date for GMT 6.5? October? November?

@seisman
Copy link
Member Author

seisman commented Sep 19, 2023

The question is, do we want to release v0.11.0 in Jan, 2024 following our quarterly release policy, or release earlier, on the same day as GMT 6.5.

When is the planned release date for GMT 6.5? October? November?

Ping @PaulWessel

@PaulWessel
Copy link
Member

We are close but I have many non-GMT days next 2 weeks so maybe Oct 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature wanted help wanted Helping hands are appreciated
Projects
None yet
Development

No branches or pull requests

5 participants