-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the notes that high-resolution remote datasets don't support slice operations #2378
Comments
I think it makes more sense to remove the notes about "slice operation is not supported for high-resolution datasets", and add a note like:
|
Ping @GenericMappingTools/pygmt-maintainers for comments on it and review PR #2384. |
Just for context, that sentence was added originally added in #542 to the I think we'll need to be more specific on which grids support slicing (grids loaded with pygmt/pygmt/datasets/load_remote_dataset.py Lines 302 to 313 in 8aec841
Maybe reword the sentence to mention that setting a |
My main point is, the registration and gtype properties will be lost after almost any grid operations and slicing is just one of them. So the note should be very general rather than focus on "slicing" only. |
Mm, you're right. It's not just slicing that causes the registration and gtype properties to be lost, though slicing is one of the more common operations that could be mentioned as an example. Let me make an inline comment on #2384. |
In the documentation of all remote datasets (e.g., https://www.pygmt.org/v0.8.0/api/generated/pygmt.datasets.load_earth_age.html), we have notes like:
The notes are inaccurate:
These are all caused by the limitations of the xarray accessors (#499), so it should be documented in a single place (as done in PR #2375). So, I think we should remove these notes for remote datasets, or have a note saying that "The grid registration and gtype information may lose after grid operations." and link to the GMT xarray accessor documentation (i.e., #2375) for reference and workarounds.
The text was updated successfully, but these errors were encountered: