Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_plot_shapefile by downloading cache files first #1789

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix test_plot_shapefile by downloading cache files first #1789

merged 1 commit into from
Mar 7, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 7, 2022

Description of proposed changes

Fixes #1788

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added this to the 0.6.0 milestone Mar 7, 2022
@seisman seisman added skip-changelog Skip adding Pull Request to changelog maintenance Boring but important stuff for the core devs labels Mar 7, 2022
@seisman seisman requested a review from weiji14 March 7, 2022 02:08
weiji14
weiji14 approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But do you want this PR to close #1788, or keep it open to track the upstream bug?

@seisman
Copy link
Member Author

seisman commented Mar 7, 2022

I believe ogr2ogr can't do the shapefile->gmt conversion if metadata files like .shx are missing.

GenericMappingTools/gmt#6400 was opened to make sure that GMT raises a friendly error rather than crashing. Thus, any upstream changes won't affect this PyGMT test, so closing #1788.

@seisman seisman merged commit d4e3758 into main Mar 7, 2022
@seisman seisman deleted the fix-shp-test branch March 7, 2022 02:47
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Fix test_plot_shapefile by downloading cache files first (GenericMapp…
add49e2 
…ingTools#1789)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Segfault when running test_plot_shapefile without the dbf and shx files
2 participants
@seisman @weiji14