Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parts of the contributing guides to the website #1205

Closed
seisman opened this issue Apr 12, 2021 · 5 comments · Fixed by #1335
Closed

Move parts of the contributing guides to the website #1205

seisman opened this issue Apr 12, 2021 · 5 comments · Fixed by #1335
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@seisman
Copy link
Member

seisman commented Apr 12, 2021

In PR #1185, we moved the maintainer's guides to the documentation (the doc directory), since the guides are too long and are much easier to read on the documentation website (using the sidebar links).

Similarly, the contributing guides is also too long, with more than 500 lines now, and still increasing (#1119, #1113).

I don't think it's a good idea to move the whole CONTRIBUTING.md file to the documentation. Instead, I think we can only keep basic guides in the repository, but move advanced guides to the documentation.

Basic guides are mainly for first-time contributors or people who are not familiar with github workflows (it means people like me will never read it). IMHO, basic guides can include sections like:

  • What Can I Do?
  • How Can I Talk to You?
  • Reporting a Bug
  • Code Review process
  • General guidelines

Other sections like rules/styles of our documentation and code, instructions to run tests and generate baseline images, are too technical and can be grouped as advanced guides (even people like me need to read it sometimes).

This is just a quick idea, and I'm not sure if it would cause more confusion, but I'd like to hear your thoughts.

@seisman seisman added the question Further information is requested label Apr 12, 2021
@core-man
Copy link
Member

I feel we could move all of them to the documentation instead of putting them in two places. We could re-group the guides into basic and advanced ones as your suggestion. In this way, experienced contributors could still quickly find what they need, while new contributors can also know all the things in one place.

@maxrjones
Copy link
Member

I like scikit-learn's stucture, which has a minimal CONTRIBUTING.md that primarily provides links to the contributing guides on their website. I prefer to keep some sort of CONTRIBUTING.md because people interested in contributing could do a quick search for it and I would not want to risk losing any potential contributors due to its absence.

@seisman
Copy link
Member Author

seisman commented Apr 13, 2021

Yes, I agree we should at least have a minimal CONTRIBUTING.md file.

@seisman seisman added documentation Improvements or additions to documentation and removed question Further information is requested labels Apr 13, 2021
@core-man
Copy link
Member

If we want a minimal CONTRIBUTING.md, how about the following TOC of CONTRIBUTING.md:

  • Contributing Guidelines
  • Ground Rules
  • Quick Links (some links to the planned contributing guides on the website, e.g., What Can I Do?, How Can I Talk to You?, Reporting a Bug)

Meanwhile, we could move all the sections to the website.

@weiji14 weiji14 added the help wanted Helping hands are appreciated label Jun 6, 2021
@maxrjones
Copy link
Member

I will open a PR based on the conversation here, because if possible it would be nice to get this in for v0.4.0 in advance of the July/August sprint/workshop.

@maxrjones maxrjones changed the title Move parts of the contributing guides to the website? Move parts of the contributing guides to the website Jun 15, 2021
@maxrjones maxrjones removed the help wanted Helping hands are appreciated label Jun 15, 2021
@maxrjones maxrjones self-assigned this Jun 15, 2021
@seisman seisman added this to the 0.4.0 milestone Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants