Dateline crossing dcw polygons and tiles #8318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For odd reasons, the US, Russia and Fiji all cross the 180-meridian and yield idiotic west/east limits like 172.436/-66.9489, resulting in no plots for commands like gmt grdimage @earth_relief_05m -B -RUS -png USA -Vi This PR checks for this cse and now gives sensible continuous longitudes.
Add test script for the three 180-meridian DCW polygons USA, Russia, and Fiji.
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added images
Modified images
Report last updated at commit 98545fe |
Esteban82
approved these changes
Jan 22, 2024
remkos
added a commit
that referenced
this pull request
Jan 23, 2024
* 'master' of https://github.com/GenericMappingTools/gmt: (24 commits) Bump actions/cache from 3 to 4 (#8323) Add longoptions support for psbarb. (#8283) Add longoptions support for nearneighbor. (#8281) Add longoptions support for makecpt. (#8280) Add longoptions support for kml2gmt. (#8279) Add longoptions support for inset. (#8278) Add longoptions support for grdvolume. (#8276) Add longoptions support for grdview. (#8275) Batch #8 of longoptions translation tests. (#8272) Enable longoptions support for grdconvert. (#8197) Enable longoptions support for grd2xyz. (#8178) Update gmt_init.c Allow -A even if movie is not generated typos Update std-opts.rst Same case, clearer titles Dateline crossing dcw polygons and tiles (#8318) Missed a space before -T synopsis Improve windbarb docs, synopsis and usage for -Q and parsing of -Q (#8314) Let grdmix create RGB imagea for red, green, blue grids in 0-255 range (#8316) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See #8266 for background. We kept getting a bad west/east string for the three polygons USA, RU, and FJ that crossed the 180-degree meridian. In combination with tiled remote data sets we ended up with no plot, but always worked well with non-tiled (e.g., 06m and lower resolutions). Ensuring monotonically increasing longitudes from west to east fixed this, and I added a new test just so we stay alert (dcw_180_crossers.sh).
The new test pass:
While master gives empty frames: