Relax the need for -R in grdproject #8286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to be that way but in pursuit of a bug we added the requirement that -R be set if -J was given. This resulted in -180/180/-90/90 with -JH10c giving grid wesn as 0/10/-5/5 and no longer geographic, but that is not really our business. I have removed that check and should no longer bother anyone. All tests pass now, including the examples posted.
joa-quim
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be that way but in pursuit of a bug we added the requirement to grdproject that -R be set if -J was given a size. This resulted in a global grid (-180/180/-90/90) given -JH10c gave the final grid wesn as 0/10/-5/5 and no longer geographic, but that is not really our business. I have removed that check and should no longer bother anyone. All tests pass now, including the examples posted.
gmt grdproject @earth_relief_01d_g -JH10c -Gtmp.nc