Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable longoptions support for grdselect. #8228

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

rbdavis
Copy link
Contributor

@rbdavis rbdavis commented Dec 21, 2023

Description of proposed changes

Python differences:

No Python module.

Julia differences:

No Julia module.

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@rbdavis rbdavis requested a review from a team December 21, 2023 02:20
{ 0, 'L', "linefile", "", "", "", "", GMT_TP_STANDARD },
{ 0, 'M', "margins", "", "", "", "", GMT_TP_STANDARD },
{ 0, 'N', "nans",
"l,h", "lower,higher",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using here "lower|lower_than,higher|higher_than"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am find with those aliases, make it so @rbdavis

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See remko's suggestion and my endorsement

@rbdavis rbdavis merged commit 35edfd0 into master Jan 8, 2024
6 checks passed
@rbdavis rbdavis deleted the longopts-grdselect branch January 8, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants