Enable longoptions support for grdedit. #8221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remkos
requested changes
Dec 21, 2023
src/longopt/grdedit_inc.h
Outdated
| { 0, 'G', "", | ||
| "", "", | ||
| { 0, 'E', "transform", | ||
| "a,e,h,l,r,t,v", "hvflip,xyswap,hflip,rot90counterclock,rot90clock,transpose,vflip", |
There was a problem hiding this comment.
the rot90... becomes very long.
Can we do (at least as alternative) "rotleft" and "rotright". It should be obvious that it is by 90º.
There was a problem hiding this comment.
****Maybe rot90ccw and rot90cw are more specific than just a rotation of unspecific value. I agree that rot90counterclock is too long and even not long enough since it begs for the "wise" at the end.
There was a problem hiding this comment.
Well, it would be hard to rotate a 2D grid by anything else than increments of 90º. But, yes, I would also prefer "rot90ccw" and "rot90cw"
PaulWessel
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Python differences:
No Python module.
Julia differences:
Changed -C adjust_inc (Julia doc error?) to cmdhist|command_history.
Changed -D header (conflict with common longoptions) to
netcdf|netCDF|ncheader.
Changed -E header (conflict with common longoptions) to transform.
Changed -S wrap (conflict with common longoptions) to lonshift_region.
Changed -T toggle_reg to match existing grdfilter longoptions
toggle_registration|toggle.
Fixes #
Reminders