Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use GMT_THEME=cookbook in cookbook scripts #6649

Closed
seisman opened this issue May 1, 2022 · 7 comments
Closed

Don't use GMT_THEME=cookbook in cookbook scripts #6649

seisman opened this issue May 1, 2022 · 7 comments
Assignees
Labels
documentation Improve documentation

Comments

@seisman
Copy link
Member

seisman commented May 1, 2022

In some examples in the cookbook, we use the GMT_THEME=cookbook setting. For example:

image

Why do we use it? Users may be confused that why GMT_THEME=cookbook is always presented in these examples.

@seisman seisman added the documentation Improve documentation label May 1, 2022
@joa-quim
Copy link
Member

joa-quim commented May 1, 2022

Agree.

@maxrjones
Copy link
Member

It's included so that all the output images don't have different font and pen sizes due to the modern mode conf default of auto, which would look bad.

@seisman
Copy link
Member Author

seisman commented May 2, 2022

It's included so that all the output images don't have different font and pen sizes due to the modern mode conf default of auto, which would look bad.

I'm not fully convinced by this reason. If the images look bad due to the different font and pen sizes, we should update the scripts so that all basemaps have similar dimensions (thus similar font and pen sizes).

@maxrjones
Copy link
Member

It's included so that all the output images don't have different font and pen sizes due to the modern mode conf default of auto, which would look bad.

I'm not fully convinced by this reason. If the images look bad due to the different font and pen sizes, we should update the scripts so that all basemaps have similar dimensions (thus similar font and pen sizes).

I recommend submitting a PR for one section of the cookbook with your solution rather than using the cookbook theme so that we can review the appearance.

@joa-quim
Copy link
Member

Now close this?

@seisman
Copy link
Member Author

seisman commented May 13, 2024

there are still a lot to update

@seisman
Copy link
Member Author

seisman commented Jun 3, 2024

Closed by #8509.

@seisman seisman closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improve documentation
Projects
None yet
Development

No branches or pull requests

3 participants