-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding cmocean colour maps #6284
Comments
Seems useful. Maybe it is useful for you to look at our admin/build-scientific-colors-cpt.sh for converting their CPT into our master format (normalized 0/1 or -1/+1, depending on whether there is a hinge or not). |
The scientific colour maps workflow checks for releases using their Zenodo archive. It doesn't look like cmocean is on Zenodo, but we could probably query https://github.com/matplotlib/cmocean for new releases. |
Yes, @PaulWessel. I can either convert their RGB text files, or get the GMT4 formatted files from cpt-city and do the normalisation. I'll certainly look at your script. Thanks for the hint. @meghanrjones : Yes, that would be a start, but most likely the updates would be in the python scripts, not in the underlying colour maps. |
I'm getting well on my way with this. I'm now getting Kirsten's own CPT files from here: https://github.com/kthyng/cmocean-gmt
There are no foreground, background or NaN colours defined in these maps. Shall I leave them out in our own versions? |
Great. As for the BNF, if they have none then do not add any - this means GMT supplies its default settings which is all we can do without adding new things. While renaming to a non-conflicting name is fine, perhaps we should at least discuss what alternatives there are? I can think of this one:
I am just concerned how to handle 1000s CPT files eventually - we are not there yet but probably because we do not directly support cpt-city... |
I think a directory structure is a wise, flexible, and workable solution. I'll just need to check how the -C option behaves when using a slash in the name. I think the slash is preferred above all else, as that becomes natural to me.
|
Another few thoughts:
|
Yes, I think we are talking about a handful of bytes so the duplication is OK and simplifies operations, including lack of symlinks (or done differently) on Windows. Yes, I assume output form makecpt would be sorted per collection and maybe
I think the gmt/ part is optional and if no directory given we default to gmt/ as you say. |
I got a lot further with this. There are just a few that I have not sorted out, see at the top of the list of Where should those go? |
I think these are basically cptcity: cubhelix, dem1, dem4, elevation These should be in the gmt list for sure: globe, mag, seis |
* Introducing cmocean colormaps (#6284) * Move Fabio Crameri's colormaps to subdirectory (#6284) * Move matplotlib colormaps to subdirectory (#6284) * gmt_is_cpt_master: return full name of cpt after matching master was found (#6284) * Move gmt, google, gmt and panoply colormaps into subdirectories (#6284) * Move last unsorted colormaps into subdirectories (#6284) * Identify paired.cpt as categorical (#6284) * Update GMT_App_M*.sh scripts and colormaps documentation in cookbook (#6284) * Change permission on GMT_App_M_1e.sh * Make gmt_is_cpt_master work for full file names (#6284) * Renames cpt subdirectory from "crameri" to "SCM7" (#6284) * Rename SCM7 to SCM (#6284) * Add missing comma * Update documentation for new color maps Co-authored-by: Paul Wessel <[email protected]>
Description of the desired feature
I'm interested in adding the cmocean colour maps: https://matplotlib.org/cmocean/
For the paper in "Oceanography", see http:https://dx.doi.org/10.5670/oceanog.2016.66
Are you willing to help implement and maintain this feature? Yes
The text was updated successfully, but these errors were encountered: