-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release GMT 6.0.0rc4 #1471
Comments
Was told by Wiley they are working on the galleys. We better do rc4 as training before the real release. I will start on the top. |
Hi @seisman, are you able to verify that tests pass and check taht box above? Also, we still dont have a changelog I think so I guess we can check that as well. I can run tests tonight at home and then I can build the tarballs and macOS bundle as well, and give links to those for @joa-quim to build win installers. |
The tests are still running, see https://dev.azure.com/GenericMappingTools/GMT/_build/results?buildId=2381&view=results. It may take one more hour for the Windows tests. |
@PaulWessel There are two new failing tests on Windows, ex29 and ex39. |
Looks OK to me. It is just switching from rainbow to turbo CPT so the images are almost entirely different, no? Do you see anything else? I would just update the orig PS. |
But why these two tests pass on macOS and Linux? |
Well, they both fail for me under macOS. Perhaps the PS were not merged? |
Running the scripts directly shows that the generated PS is different from the orig PS. Don't know why ctests didn't detect those for me. |
Lines 169 to 173 in 1e4c65a
In the gmtest script of examples, it creates symbolic links for *.bat, *.sh and *.ps. Why does the *.ps symbolic links needed? |
This is cryptic code from Florian. It sets up links to files in the original ex?? directory so that the script will run in the temporary build directory (some of them access local files and they would not be found). I am pretty sure I replaced the BLOBIGNORE since it nevern worked for me on macOS and we could not figure out why. But I agree in principle that the gm commands specifies the path to the original PS so why... |
At home I got on error in proj4.sh - presumably because macports installed goal 3.0.1 and there may be some subtle differences. How are things on your end? |
I have one failing test on my local mac. GMT_App_P_2.sh fails because it can't find gmt_shell_functions.sh in its local directory. The scheduled builds reports 0 failing tests on macOS, 1 failing test ( |
Should the line . gmt_shell_functions.sh instead use the source directory path? E.g. . ${GMT_SOURCE_DIR}/src/gmt_shell_functions.sh |
Yes, it should be. The test failed suddenly because I removed GMT's bin from PATH, so |
There are 11 failing and 3 timeout tests on Windows. Look good to me. |
OK, all committed so checking the box. |
The DOI of the G3 paper is out: 10.1029/2019GC008515, although it's not activated yet. I think we can update the citation information before 6.0.0rc4 is out. |
Should we enter that now before I build the tarballs or wait for 6.0.0? |
OK, we can wait for the 6.0.0 release. |
Tarballs and macOS bundle built:
In ftp:https://ftp.soest.hawaii.edu/pwessel/release |
ftp:https://ftp.soest.hawaii.edu/pub/pwessel/release should be ftp:https://ftp.soest.hawaii.edu/pwessel/release |
Damn it, forgot to change to Release build. Restarting |
OK, please try again. The links are the same but the files should have been updated. |
@joa-quim The win32 installer works, but the win64 one still has the same problem. Can you verify that you updated the win64 installer, and also provide the md5sum value. |
Fine(ally). And the 32-bits https://www.dropbox.com/s/vgf68rl45k2008r/gmt-6.0.0rc4-win32.exe?dl=0 |
I compiled the source package, and tested the macOS bundle and Windows installers. They all work well. For #1522, I think we can merge it into 6.0, then @PaulWessel can rebuild the tarballs and bundle. No need to rebuild the Windows installers for @joa-quim. |
Revsied tarballs and macOS bundle built after merging #1522:
In ftp:https://ftp.soest.hawaii.edu/pwessel/release |
Tested again and all are good. |
@PaulWessel I'll do the tag and release tasks if you think it's OK. |
Yes, please I think we are good to go. |
Done in https://github.com/GenericMappingTools/gmt/releases/tag/6.0.0rc4. Unlike previous releases, I uploaded a gmt-6.0.0rc4-checksums.txt which lists the sha256sums of the 5 packages. The reasons are:
Let me know if you prefer md5sum instead. |
No, I have no opinion on this. On macOS we can use shasum -a 256. We should then modify admin/build-release.sh to use shasum instead. |
The conda-forge build is ready, after applying the patches in #1527 and #1528. It's waiting for approval. I also tested the homebrew recipe for 6.0.0rc4 locally, and it works fine. |
The conda-forge package is ready. |
Should the various recipes for fink, macports, homebrew and more go into the admin directory with build-release.sh etc? Seems to me these things belong with the distro (even though admin is not included in the tarballs and builds). |
No need to include these recipes. |
So where do they live? Remko kept the fink recipe in the gmt tree (subversion, GMT4). Sandwellʻs student shared a macports recipe as a template with me and I will dig it out. I dont think we have a macports recipe otherwise. |
The macports recipe is available from their github repository, i.e. https://github.com/macports/macports-ports/tree/master/science/gmt5, and I just submitted a gmt6 subport, which is still waiting for the maintainer's approval. |
I think you can also sign up with your email and the connect you zenodo account with your GitHub account. No difference, but one less password to remember.
I believe you need to click the "grant" button after "GenericMappingTools" so that zenodo can read the GMT repositories. |
Not sure if zenodo works for our case. As I understand it, when we make a github release, zenodo will automatically fetch the tarball, archive the repository and issue a DOI. However, if we want to reserve a DOI before a release, we have to upload the tarball to zenodo manually. See zenodo/zenodo-docs-user#47 for a short discussion. |
Thanks, looks like I might as well get a separate non-GitHub-connected zenodo account. |
FYI, we are planning to get an SSL certificate and use https to get to the SOEST data server. Hopefully in a few days. I have already installed the data files on gmtserver so once it works we can switch over the redirect and update ConfigDefault.cmake. |
Hi, not sure why the homebrew formula checkbox is checked. Anyway, I'll probably skip making a formula for rc4, since the homebrew maintainer prefers to wait on final release. See this comment: Homebrew/homebrew-core#41119 (comment) |
On a second thought, I can still push a formula to my homebrew fork 😉 So, if you're interested in testing rc4 installation via homebrew, you can do:
|
@claudiodsf I tested homebrew with rc4 locally, and it worked well for me. So I checked the checkbox. |
Version: 6.0.0rc4
Before release:
src/gmt_make_*.sh
to update some .c and .h filescmake/ConfigDefault.cmake
GMT_VERSION_YEAR
is current yearGMT_PACKAGE_VERSION_*
is correctly setGMT_LIB_SOVERSION
is correctly setGMT_PUBLIC_RELEASE
toTRUE
Release:
After release:
GMT_PACKAGE_VERSION_*
incmake/ConfigDefault.cmake
set (GMT_PUBLIC_RELEASE TRUE)
line3rd-party update
The text was updated successfully, but these errors were encountered: