Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceMap directory is incorrect #25

Closed
grantralls opened this issue Sep 2, 2021 · 3 comments
Closed

SourceMap directory is incorrect #25

grantralls opened this issue Sep 2, 2021 · 3 comments

Comments

@grantralls
Copy link
Contributor

grantralls commented Sep 2, 2021

By the tsc config, ts expects the source maps to be in sketch/sketch/build.js.map. The source maps are actually generated into build/build.js.map. I was able to fix the issue in my own project by changing the map root setting in tsconfig to ../build.

You can confirm the issue by walking through the following process...

  1. clone a clean copy of the repo.
  2. npm i
  3. npm run start-compile
  4. check the last line in build/build.js
@grantralls
Copy link
Contributor Author

It should be noted that the sourceRoot also needs to be updated to get the proper sources. I decided to remove both options sourceRoot and mapRoot to see if the automatic TS settings would do the trick and it did!

@Gaweph
Copy link
Owner

Gaweph commented Sep 7, 2021

Good catch. Sorry for delay in responding. If you would like to do a PR with the relevant changes I would be happy to approve 👍

@Gaweph Gaweph closed this as completed Sep 7, 2021
@grantralls
Copy link
Contributor Author

#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants