Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define is missing the visibility field #77

Closed
noughtmare opened this issue May 3, 2021 · 3 comments · Fixed by #78
Closed

Define is missing the visibility field #77

noughtmare opened this issue May 3, 2021 · 3 comments · Fixed by #78

Comments

@noughtmare
Copy link
Contributor

noughtmare commented May 3, 2021 •
edited
Loading

Globals, functions and global aliases can have a visibility attribute, but in this package only globals have a visibility attribute.
@elliottt
Copy link
Collaborator

elliottt commented May 3, 2021

Good point! Would you be interested in adding this?

@noughtmare
Copy link
Contributor Author

Yes, I will also look into adding it to the bc parser.

@elliottt
Copy link
Collaborator

elliottt commented May 3, 2021

Thank you!

@noughtmare noughtmare mentioned this issue May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More visibility and linkage noughtmare/llvm-pretty
2 participants
@elliottt @noughtmare