-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2d Galsim interpolants in JAX #54
Comments
Would be nice to get the residuals in a use-case for the 2D interpolants |
Oh yeah! It is on my list. I think though I'll just start a PR with tests to codify what they are explicitly. |
FYI. Along the line to see if your code could be proposed to JAX, I was looking to Scipy 2D interpolation API, but (may be you know) the doc of scipy.interpolate.interp2d is mentioning that the API is deprecated since the 1.10.0 version and will be removed in the 1.13.0. The new API is documented here as scipy.interpolate.RegularGridInterpolator. Now, if you are interested, I had opened a discussion in May 22 (!) on JAX here and I have proposed at that time code that you will find at the end of the thread. It would be nice to make some comparisons if you do not mind. My pb was the edges as usual... |
Feel free to compare away. My goal is to implement what is in galsim so that I can use it for other projects. |
@beckermr implemented a jax version of 2D galsim interpolants in this notebook: https://github.com/beckermr/misc/blob/main/work/jax_dmdet_hacking/interp.ipynb
Might be good idea to integrate them into jax-galsim
The text was updated successfully, but these errors were encountered: