Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position class is not pytree #40

Closed
ismael-mendoza opened this issue Jul 17, 2023 · 1 comment
Closed

Position class is not pytree #40

ismael-mendoza opened this issue Jul 17, 2023 · 1 comment

Comments

@ismael-mendoza
Copy link
Collaborator

ismael-mendoza commented Jul 17, 2023 •
edited
Loading

I believe we need to add the appropriate decorator to make this a pytree (we did implement the flatten and unflatten methods)

https://github.com/GalSim-developers/JAX-GalSim/blob/05e0863c67e5f2296b35b90e8ad2550d110c2f44/jax_galsim/position.py#L8C4-L8C4
@ismael-mendoza
Copy link
Collaborator Author

actually ok because we only ever use the PositionD and PositionI directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ismael-mendoza