-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary null pointer checks #4
Comments
Hello @elfring , Thank you very much for your contribution, it is much appreciated! Actually, the code problems you have linked, exist in the open source algorithm which was used by this project. It is called Direct Sparse Odometry and their repository can be found here: https://github.com/GSORF/Visual-GPS-SLAM#dependencies So, do you agree to close your issue here? Thank you and kind regards, |
Do you care for further improvements in related software areas? |
Yes! |
Under which circumstances will adjusted software components be integrated here? |
This project is not so much about using the DSO specifically. It may be used with any Visual SLAM software because all the sensor data fusion is done in a Blender / Python implementation. The DSO was just used as an example to generate the trajectories for the observations in the Kalman filter. And as the dependencies are not included as git submodules, they need to be copied over here manually from their original repository. This is why the dependencies will not be updated in this repository. Thank you for your comment. Kind regards, |
🔮 Can it become easier to identify and improve bundled software components? |
In general: Sure, but I don't know how. Kind regards, |
I suggest to stress the distinction between own and external software.
Will the corresponding clarification trigger any collateral evolution then? |
Thank you for your suggestions, I will extend the documentation to this regard. It is obviously not clear enough from the README, I will therefore improve it on this weekend and then close this issue. Thank you, kind regards, |
I have now updated the README file and described my modifications in more detail, see here: Therefore I will now close this issue. Thank you for your suggestion. |
Extra null pointer checks are not needed in functions like the following.
The text was updated successfully, but these errors were encountered: