-
Notifications
You must be signed in to change notification settings - Fork 69
/
ChangeLog0.8
6601 lines (5048 loc) · 264 KB
/
ChangeLog0.8
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2005-08-10 Bastien Nocera <[email protected]>
* metadata/rb-metadata-gst.c: (rb_metadata_load):
Use filesrc for local files, instead of gnomevfssrc (with
brain-surgery performed by Jonathan Matthew <[email protected]>)
(Closes: #313088)
Should fix some infinite loops importing files as in #313084
* metadata/rb-metadata-mm.c: removed, it's unused
2005-08-09 Colin Walters <[email protected]>
* data/rhythmbox.desktop.in (MimeType): Remove x-directory from
list; we shouldn't advertise as a generic directory processor
since Rhythmbox is only useful for particular directories.
2005-08-10 James Livingston <[email protected]>
* INSTALL.quick: updated for the first time since 0.5.0. Now lists the
requirements to build cvs/0.9 - a Gnome 2.10 platform, a recent
GStreamer 0.8 and totem-plparser >= 1.1.3
2005-08-05 James Livingston <[email protected]>
* sources/rb-iradio-source.c: (rb_iradio_source_do_query): fix a
slight error in the iradio patch.
2005-08-04 James Livingston <[email protected]>
* shell/rb-shell.c: (rb_shell_construct),
(rb_shell_window_state_cb), (rb_shell_window_delete_cb),
(rb_shell_set_visibility_impl): Patch from Jaap A. Haitsma
<[email protected]> to make the tracy icon work better. It now shows
the window whenever it is not user-visible (including minimised or on
another workspace).
2005-08-04 James Livingston <[email protected]>
* sources/rb-iradio-source.c: (rb_iradio_source_dispose),
(rb_iradio_source_do_query): Patch from Jonathan Matthew
<[email protected]> that stops the iradio source attempting to
use a query before the database it fully loaded. (Closes 145217)
Also removed unused fields from RBIRadioSourcePrivate.
2005-08-03 James Livingston <[email protected]>
* iradio/rb-station-properties-dialog.c:
(rb_station_properties_dialog_sync_entries):
* widgets/rb-song-info.c: (rb_song_info_sync_entries_multiple),
(rb_song_info_sync_entry_single): Only write tags if they have
actually changed. Patch from Jonathan Matthew <[email protected]>
(Closes 312336)
2005-08-01 Bastien Nocera <[email protected]>
* shell/rb-shell-player.c: (rb_shell_player_init): don't use
rb_image_new_from_stock (which mirrors icons for RTL languages) when
the icons are in GTK+ (Closes: #312264)
2005-08-01 Bastien Nocera <[email protected]>
* rhythmdb/rhythmdb.c: (emit_entry_changed): fix warning by removing
unused variable
2005-08-01 James Livingston <[email protected]>
* widgets/rb-entry-view.c: (rb_entry_view_set_property): patch from
Jonathan Matthew <[email protected]> to fix a crasher when an
EntryView kept a cached copy of an iterator.
2005-08-01 James Livingston <[email protected]>
* player/rb-player-gst.c: (process_tag), (found_tag_cb),
(rb_player_construct):
* shell/rb-shell-player.c: (info_available_cb): patch from Jonathan
Matthew <[email protected]> to use iradio station metadata if the
user hasn't provided them (Closes 307899)
2005-07-31 James Livingston <[email protected]>
* rhythmdb/rhythmdb-query-model.c:
(rhythmdb_query_model_entry_deleted_cb): fix crasher where entry
remove signal was wrongly emitted.
2005-07-31 James Livingston <[email protected]>
* rhythmdb/rhythmdb.c: (rhythmdb_process_metadata_load): don't reset
the rating and last-played time when reloading track metadata (if the
file has changed).
2005-07-30 James Livingston <[email protected]>
* sources/rb-iradio-source.c: (rb_iradio_source_constructor),
(genre_selected_cb), (genre_selection_reset_cb): Handle the
RBPropertyView 'property-selection-reset' signal in iradio source.
* rhythmdb/rhythmdb-query-model.c:
(rhythmdb_query_model_entry_changed_cb): correctly emit changed
signals whether the entry was removed or not.
* rhythmdb/rhythmdb-marshal.list:
* rhythmdb/rhythmdb-property-model.c:
(rhythmdb_property_model_set_property),
(rhythmdb_property_model_entry_removed_cb):
* rhythmdb/rhythmdb-query-model.c:
(rhythmdb_query_model_class_init),
(rhythmdb_query_model_filter_out_entry),
(rhythmdb_query_model_remove_entry):
* rhythmdb/rhythmdb-query-model.h:
* rhythmdb/rhythmdb.c: (rhythmdb_class_init), (rhythmdb_init),
(free_entry_changes), (emit_entry_changed),
(rhythmdb_commit_internal),
(rhythmdb_process_queued_entry_set_event), (rhythmdb_entry_sync),
(rhythmdb_entry_set):
* rhythmdb/rhythmdb.h:
Emit 'entry-removed' signal from query model, to distinguish between
removed and filters entried. Emit entry-changed signal for all changed
properties.
Patches from Jonathan Matthew <[email protected]> (Closes 149799)
2005-07-30 James Livingston <[email protected]>
* data/glade/station-properties.glade: remove extraneous string that
was causing translators problems.
2005-07-30 James Livingston <[email protected]>
* rhythmdb/rhythmdb.c: (rhythmdb_entry_song_get_type),
(rhythmdb_entry_iradio_get_type): A small thread safety fix.
2005-07-30 James Livingston <[email protected]>
* remote/bonobo/rb-remote-bonobo.c:
(rb_remote_bonobo_player_notify_cb): Patch from Jonathan Matthew
<[email protected]> to fix an assertion in the bonobo code.
2005-07-30 James Livingston <[email protected]>
* player/rb-player-gst.c: (rb_player_class_init),
(rb_player_finalize), (emit_signal_idle), (eos_cb), (error_cb),
(deep_notify_cb), (buffering_cb), (rb_player_construct):
* player/rb-player.h:
* rhythmdb/rhythmdb.c: (rhythmdb_is_busy):
* rhythmdb/rhythmdb.h:
* shell/rb-shell-player.c: (rb_shell_player_class_init),
(rb_shell_player_init), (rb_shell_player_set_property),
(rb_shell_player_get_property), (rb_shell_player_open_location),
(info_available_cb), (buffering_cb):
* shell/rb-shell.c: (rb_shell_construct):
* shell/rb-statusbar.c: (rb_statusbar_init),
(rb_statusbar_sync_status), (poll_status),
(rb_statusbar_set_progress), (rb_statusbar_entry_view_changed_cb):
* shell/rb-statusbar.h: Patch from Jonathan Matthew
<[email protected]> to give a buffering indication for iradio
sources (Closes 309708)
2005-07-29 James Livingston <[email protected]>
* widgets/rb-song-info.c: (rb_song_info_sync_entry_single): Fix issue
where editing some tags may corrupt the tarck number. (Closes 305637)
2005-07-29 James Livingston <[email protected]>
* sources/rb-playlist-source.c: (rb_playlist_source_constructor):
* sources/rb-sourcelist.c:
* widgets/Makefile.am:
* widgets/rb-entry-view.c: (rb_entry_view_append_column),
(rb_entry_view_constructor): Patch from Nickolay V. Shmyrev
<[email protected]> to use GTK's TreeView rather than our own
implementation. (Closes 169152)
Files removed:
* widgets/gtkrbtree.h:
* widgets/gtktreeprivate.h:
* widgets/rb-tree-view-column.c:
* widgets/rb-tree-view-column.h:
* widgets/rb-tree-view.c:
* widgets/rb-tree-view.h:
2005-07-28 James Livingston <[email protected]>
* rhythmdb/rhythmdb.c: (rhythmdb_event_free), (rhythmdb_shutdown),
(rhythmdb_thread_create), (rhythmdb_get_readonly),
(rhythmdb_read_enter), (rhythmdb_read_leave),
(rhythmdb_entry_set_internal), (rhythmdb_entry_set): Several rhythmdb
thread-safety fixes. Patch from Jonathan Matthew
<[email protected]> (closes 311382)
(rhythmdb_entry_register_type): Another thread-safety fix
2005-07-27 James Livingston <[email protected]>
* rhythmdb/rb-refstring.h: Fix occasional crasher when a volume is
umounted.
2005-07-26 James Livingston <[email protected]>
* data/ui/rhythmbox-ui.xml:
* shell/rb-shell.c: (rb_shell_construct):
* sources/rb-iradio-source.c: (rb_iradio_source_class_init),
(stations_view_drag_data_received_cb), (impl_show_popup):
* sources/rb-sourcelist.c: (rb_sourcelist_class_init),
(rb_sourcelist_set_property), (rb_sourcelist_get_property),
(rb_sourcelist_new), (button_press_cb):
* sources/rb-sourcelist.h: Make popup menus work correctly in the
sourcelist and entry view, also have some better popup menu entries.
Patch from Jonathan Matthew <[email protected]> (Closes 311493)
* widgets/rb-entry-view.c: (rb_entry_view_constructor),
(rb_entry_view_button_press_cb), (rb_entry_view_popup_menu_cb): Make
the entryview respond to Shift-F10/Menu with the popup menu. Patch
from Jonathan Matthew <[email protected]> (Closes 152650)
* lib/rb-tree-dnd.c: (rb_tree_dnd_button_press_event_cb): Allow
columns to be resized when the first track is selected. Patch from
Jonathan Matthew <[email protected]> (Closes 172654)
2005-07-26 James Livingston <[email protected]>
* shell/rb-shell.c: (rb_shell_db_error_cb),
(rb_shell_db_entry_added_cb), (idle_handle_load_complete),
(rb_shell_load_uri_impl): Undo a patch that got accidently commited in
my last commit. Oops.
2005-07-26 James Livingston <[email protected]>
* data/glade/create-playlist.glade:
* shell/rb-shell.c: (rb_shell_db_error_cb),
(idle_play_added_entry_cb), (rb_shell_db_entry_added_cb),
(idle_handle_load_complete), (rb_shell_load_uri_impl):
* widgets/rb-query-creator.c: (rb_query_creator_load_query),
(rb_query_creator_get_limit): use a spin button, rather than a text
entry, for the limit in the playlist editor.
2005-07-23 James Livingston <[email protected]>
* sources/rb-library-source.c: (rb_library_source_free_list_data),
(rb_library_source_cmd_choose_genre),
(rb_library_source_cmd_choose_artist),
(rb_library_source_cmd_choose_album): fix another memory leak
2005-07-22 James Livingston <[email protected]>
* player/rb-player-gst.c: (rb_player_finalize),
(rb_player_construct), (rb_player_sync_pipeline), (rb_player_open),
(rb_player_pause), (rb_player_set_time), (rb_player_get_time):
* widgets/rb-header.c: (rb_header_class_init), (rb_header_init),
(rb_header_finalize), (rb_header_set_property),
(rb_header_get_property), (rb_header_sync_time),
(rb_header_get_elapsed_string), (rb_header_update_elapsed),
(rb_header_tick_cb): Query GStreamer, rather than using a timer, to
determine the current playback position. Patch from Jonathan Matthew
<[email protected]> (Closes 167364)
2005-07-20 Bastien Nocera <[email protected]>
* configure.ac: update the playlist parser requirements
* shell/rb-shell-player.c: (rb_shell_player_open_location):
Avoid creating a newly-allocated string for no reason, use
totem_pl_parser_add_ignored_mimetype instead of
totem_pl_parser_add_ignored_scheme as it was meant
2005-07-18 James Livingston <[email protected]>
* rhythmdb/rhythmdb-query-model.c:
(rhythmdb_query_model_entry_changed_cb),
(rhythmdb_query_model_do_reorder):
Fix a bug in the query re-ordering code. Patch from Jonathan Matthew
2005-07-16 James Livingston <[email protected]>
* sources/rb-playlist-source.c: (rb_playlist_source_add_list_uri):
Add files dragged to a playlist to the library, so they can actually
be added to the playlist. (Closes: 300391)
2005-07-15 James Livingston <[email protected]>
* widgets/disclosure-widget.c: (cddb_disclosure_set_labels),
(expander_callback): Fix the disclosure widget, so that the show/hide
labels are not reversed.
2005-07-14 Colin Walters <[email protected]>
* rhythmdb/rhythmdb.c (rhythmdb_process_events): Kill off warning
about readonly db.
2005-07-14 Colin Walters <[email protected]>
* configure.ac: Remove -Wall since then we lose with -Werror when
new GCC warnings are introduced. Instead hardcode a list of warnings
we want.
* widgets/rb-volume.c (rb_volume_new):
* widgets/rb-tree-view.c (rb_tree_view_new):
* widgets/rb-tree-view-column.c (rb_tree_view_column_new):
* widgets/rb-song-display-box.c (rb_song_display_box_new):
* widgets/rb-rating.c (rb_rating_new):
* widgets/rb-load-failure-dialog.c (rb_load_failure_dialog_new):
* shell/rb-shell-preferences.c (rb_shell_preferences_new):
* remote/bonobo/rb-remote-bonobo.c (rb_remote_bonobo_new):
* remote/bonobo/libmain.c (rhythmbox_shlib_make_object):
* player/rb-recorder-gst.c (rb_recorder_new):
* player/rb-player-gst.c (rb_player_new):
* metadata/rb-metadata-gst.c (rb_metadata_new):
Pass extra NULL to g_object_new to silence gcc.
2005-07-12 Colin Walters <[email protected]>
* rhythmdb/rhythmdb.c (rhythmdb_commit_internal): Only queue
stats for RHYTHMDB_ENTRY_TYPE_SONG; it's a bit evil to do
http requests to all your iradio sites, doesn't really make
sense from a UI standpoint, and also apparently triggers some
valgrind errors.
2005-07-11 William Jon McCann <[email protected]>
* sources/rb-playlist-source-recorder.c (_nautilus_burn_drive_media_type_get_string):
Fix ambiguous string. (Closes: #309872)
2005-07-11 James Livingston <[email protected]>
* rhythmdb/rhythmdb-query-model.c:
(rhythmdb_query_model_entry_changed_cb),
(rhythmdb_query_model_update_limited_entries),
(rhythmdb_query_model_do_reorder):
Add support for dynamic re-ordering of the library/playlists when
metadata the affects the sorting order changes. This also fixes a bug
where it would stop playing when trying to change to the next song.
2005-07-11 James Livingston <[email protected]>
* rhythmdb/rb-refstring.c: (rb_refstring_unref):
* rhythmdb/rhythmdb.c: (rhythmdb_finalize):
More rb-refstring fixes (patch from Jonathan Matthew
<[email protected]>, Closes: 309983)
* shell/main.c: (main):
Fix intermittent crash on exit.
2005-07-10 James Livingston <[email protected]>
* rhythmdb/rhythmdb-tree.c: (rhythmdb_tree_parser_start_element),
(rhythmdb_tree_parser_end_element), (rhythmdb_tree_load):
Remove some pointless memory reallocations in rhythmdb-tree
2005-07-10 James Livingston <[email protected]>
* shell/rb-source-header.c: (rb_source_header_init),
(rb_source_header_disclosure_toggled_cb),
(rb_source_header_sync_control_state):
* widgets/disclosure-widget.c: (finalize), (class_init), (init),
(cddb_disclosure_get_type), (cddb_disclosure_new),
(cddb_disclosure_set_labels), (expander_callback):
* widgets/disclosure-widget.h:
Make the disclosure widget use GtkExpander, rather than having our own
custom widget. Closes bug 306824.
2005-07-10 James Livingston <[email protected]>
* rhythmdb/rb-refstring.c: (rb_refstring_system_init),
(rb_refstring_new_full), (rb_refstring_unref),
(rb_refstring_system_shutdown):
* rhythmdb/rb-refstring.h:
Make rb-refstrings thread safe, which should fix some intermittent
crashes on SMP/SMT systems.
2005-07-09 Paolo Borelli <[email protected]>
* sources/rb-sourcelist.c: popup the menu on keyboard shortcuts,
bug 309695.
2005-07-08 William Jon McCann <[email protected]>
* player/rb-recorder-gst.c (rb_recorder_finalize)
(rb_recorder_burn_cancel, rb_recorder_burn): Add proper
cancellation of burning process.
* data/glade/recorder.glade: Updated to use single progress
bar and speed selection.
* sources/rb-playlist-source-recorder.c (get_speed_selection)
(update_speed_combobox)
(rb_playlist_source_recorder_device_changed_cb): Allow user to
change writing speed. This is unfortunate but necessary when
combinations of factors prevent us from writing at maximum speed.
(time_to_string_text): Stolen from totem.
(progress_set_time, progress_set_fraction, burn_cd, eos_cb)
(track_progress_changed_cb): Use only one progress bar to show
overall progress, indicate the current task in italics below bar,
and show overall time remaining as progress bar text.
(response_cb): Don't show title on alert dialogs.
(insert_media_request_cb): Be specific about media types since it
only makes sense to write audio to media in the CD family. Use
cancel button instead of close. Don't show title on alert
dialogs. Make dialog modal so it can be used to set the return value
for a signal handler.
(burn_action_changed_cb): Update strings.
(ask_rewrite_disc, warn_data_loss_cb): Warn the user if the action
will cause data to be lost.
(setup_speed_combobox): New function for speed selection.
(rb_playlist_source_recorder_init): Use single progress bar. Add
speed selection. Handle n-c-b warn-data-loss signal.
* player/rb-recorder-gst.c: Fix order of includes.
Add warn-data-loss signal. Update to new n-c-b API
to support reporting time remaining.
* configure.ac: Allow n-c-b > 2.10.
2005-07-08 James Livingston <[email protected]>
* shell/rb-shell-player.c: (eos_cb):
Fix intermittent crash caused if change notification changes the
source
2005-07-08 James Livingston <[email protected]>
* iradio/rb-station-properties-dialog.c:
(rb_station_properties_dialog_rated_cb),
(rb_station_properties_dialog_sync_entries):
* rhythmdb/rhythmdb-query-model.c: (rhythmdb_query_model_init),
(rhythmdb_query_model_finalize),
(rhythmdb_query_model_entry_changed_cb),
(rhythmdb_query_model_insert_into_main_list),
(rhythmdb_query_model_insert_into_limited_list),
(rhythmdb_query_model_remove_from_main_list),
(rhythmdb_query_model_remove_from_limited_list),
(rhythmdb_query_model_update_limited_entries),
(rhythmdb_query_model_do_insert),
(rhythmdb_query_model_remove_entry):
* shell/rb-shell-player.c: (rb_shell_player_auto_adjust_rating):
* sources/rb-source.c: (rb_source_update_play_statistics):
* widgets/rb-entry-view.c: (rb_entry_view_rated_cb):
* widgets/rb-song-info.c: (rb_song_info_set_entry_auto_rate),
(rb_song_info_set_entry_rating):
Fix query and EntryView change notification, so that automatic playlists are updated
when an entry in them changes
2005-07-07 Bastien Nocera <[email protected]>
* rhythmdb/rhythmdb.c: (rhythmdb_shutdown), (read_queue),
(action_thread_main): reduce the default read_queue timeout, to try
and exit slightly faster
2005-07-07 Bastien Nocera <[email protected]>
* widgets/rb-entry-view.c: (rb_entry_view_sync_sorting),
(rb_entry_view_get_sorting_type), (rb_entry_view_set_sorting_type),
(rb_entry_view_get_sorting_order),
(rb_entry_view_set_sorting_order),
(rb_entry_view_column_clicked_cb), (rb_entry_view_constructor),
(rb_entry_view_sort_key_changed_cb):
* widgets/rb-entry-view.h: fix a number of bugs with the RBEntryView
sort-order (patch from James Livingston <[email protected]>)
(Closes: #306775)
2005-07-07 Bastien Nocera <[email protected]>
* metadata/rb-metadata-gst.c: (rb_metadata_init): support wave files
in the library (Closes: #158356)
2005-07-07 James Livingston <[email protected]>
* rhythmdb/rhythmdb-tree.c: (rhythmdb_tree_parser_start_element),
(rhythmdb_tree_parser_end_element):
Fix a memory leak, and stop some pointless string reallocation in the tree
parser.
2005-07-07 James Livingston <[email protected]>
* sources/rb-library-source.c: (rb_library_source_finalize),
(rb_library_source_constructor):
Remove GConf notifications when a RBLibrarySource is destroyed
2005-07-07 James Livingston <[email protected]>
* shell/rb-remote.c: (rb_remote_finalize), (rb_remote_class_init):
* sources/rb-ipod-source.c: (rb_ipod_source_class_init),
(rb_ipod_source_finalize):
Make rb-remote and rb-ipod-source chain the finalizers up to their
parent classes
2005-07-06 James Livingston <[email protected]>
* rhythmdb/rb-refstring.h: (rb_refstring_unref):
Avoid a crash if NULL is passed
2005-07-06 Bastien Nocera <[email protected]>
* metadata/rb-metadata-gst.c: (rb_metadata_load):
* metadata/rb-metadata.h:
* rhythmdb/rhythmdb.c: (rhythmdb_process_metadata_load):
Don't complain about text/* and image/* types being non-audio
files (patch from James Livingston <[email protected]>) (Closes: #309334)
2005-07-05 Bastien Nocera <[email protected]>
* widgets/rb-song-info.c: (rb_song_info_update_playback_error):
Avoid a crash in the properties window when no song is selected
(Patch by [email protected]) (Closes: #307993)
2005-07-05 Bastien Nocera <[email protected]>
* rhythmdb/rhythmdb-tree.c: (rhythmdb_tree_parser_end_element),
(save_entry):
* rhythmdb/rhythmdb.c: (rhythmdb_entry_set_internal):
* rhythmdb/rhythmdb.h:
Make the mountpoint struct entry use an RbRefString
(patch by James Livingston <[email protected]>)
2005-07-05 Bastien Nocera <[email protected]>
* rhythmdb/rb-refstring.c: (rb_refstring_new_full): make
RbRefString work by actually pushing it to the hash table
* lib/rb-file-helpers.c: (rb_uri_resolve_symlink):
* rhythmdb/rhythmdb.c: (rhythmdb_event_free), (add_thread_main):
Plug memory leaks in (very) often called functions
Both patches from James Livingston <[email protected]> (Closes: #309444)
2005-06-26 Dennis Cranston <[email protected]>
* sources/rb-library-source.c: Use header capitalization for
popup menu items, and add mnemonics.
* widgets/rb-header.c: (rb_header_sync): Use header capitalization.
* data/glade/library-prefs.glade: Add mnemonics and ident
contents of browser view category.
* data/glade/general-prefs.glade: Indent contents of visible
columns category.
2005-06-26 Bastien Nocera <[email protected]>
* rhythmdb/rhythmdb-tree.c: Fix a glibc/gcc warning about the
return value of fwrite_unlocked being ignored (Closes: #307649)
2005-06-25 Ignacio Casal Quinteiro <[email protected]>
* configure.ac: Added 'gl' to ALL_LINGUAS.
2005-06-19 Bastien Nocera <[email protected]>
* lib/rb-util.c: (_rb_threads_lock), (_rb_threads_unlock),
(rb_threads_init):
* remote/bonobo/Rhythmbox.idl:
* remote/bonobo/rb-remote-bonobo.c: (rb_remote_bonobo_class_init),
(rb_remote_bonobo_remote_client_proxy_init),
(rb_remote_bonobo_corba_quit),
(rb_remote_bonobo_corba_handle_file),
(rb_remote_bonobo_corba_add_to_library),
(rb_remote_bonobo_corba_next), (rb_remote_bonobo_corba_previous),
(rb_remote_bonobo_corba_skip), (rb_remote_bonobo_corba_set_rating),
(rb_remote_bonobo_corba_toggle_mute),
(convert_from_rb_remote_song), (get_song_info_from_player),
(bonobo_pb_get_prop), (bonobo_pb_set_prop),
(rb_remote_bonobo_add_player_property),
(rb_remote_bonobo_corba_get_player_properties),
(rb_remote_bonobo_song_changed_cb),
(rb_remote_bonobo_visibility_changed_cb),
(rb_remote_bonobo_player_notify_cb), (rb_remote_bonobo_acquire),
(rb_remote_bonobo_client_get_playing_song_impl),
(_rb_remote_bonobo_client_toggle_property),
(_rb_remote_bonobo_client_get_boolean_property),
(_rb_remote_bonobo_client_set_boolean_property),
(rb_remote_bonobo_client_toggle_visibility_impl),
(rb_remote_bonobo_client_get_visibility_impl),
(rb_remote_bonobo_client_set_visibility_impl),
(rb_remote_bonobo_client_toggle_shuffle_impl),
(rb_remote_bonobo_client_get_shuffle_impl),
(rb_remote_bonobo_client_set_shuffle_impl),
(rb_remote_bonobo_client_toggle_repeat_impl),
(rb_remote_bonobo_client_get_repeat_impl),
(rb_remote_bonobo_client_set_repeat_impl),
(_rb_remote_bonobo_client_set_playing),
(rb_remote_bonobo_client_play_impl),
(rb_remote_bonobo_client_pause_impl),
(rb_remote_bonobo_client_jump_next_impl),
(rb_remote_bonobo_client_jump_previous_impl),
(rb_remote_bonobo_client_quit_impl),
(rb_remote_bonobo_client_set_rating_impl),
(rb_remote_bonobo_client_seek_impl),
(rb_remote_bonobo_client_set_volume_impl),
(rb_remote_bonobo_client_get_volume_impl),
(rb_remote_bonobo_client_toggle_mute_impl):
* remote/bonobo/test-corba.c: (main):
* remote/rb-remote-client-proxy.c:
(rb_remote_client_proxy_add_to_library),
(rb_remote_client_proxy_play_uri),
(rb_remote_client_proxy_toggle_visibility),
(rb_remote_client_proxy_set_visibility),
(rb_remote_client_proxy_get_visibility),
(rb_remote_client_proxy_toggle_repeat),
(rb_remote_client_proxy_play), (rb_remote_client_proxy_pause),
(rb_remote_client_proxy_set_playing_time),
(rb_remote_client_proxy_seek), (rb_remote_client_proxy_set_rating),
(rb_remote_client_proxy_jump_next),
(rb_remote_client_proxy_jump_previous),
(rb_remote_client_proxy_quit), (rb_remote_client_proxy_set_volume),
(rb_remote_client_proxy_get_volume),
(rb_remote_client_proxy_toggle_mute):
* remote/rb-remote-client-proxy.h:
* remote/rb-remote-common.h:
* remote/rb-remote-proxy.c: (rb_remote_proxy_base_init),
(rb_remote_proxy_load_uri), (rb_remote_proxy_set_visibility),
(rb_remote_proxy_get_visibility),
(rb_remote_proxy_set_playing_time), (rb_remote_proxy_seek),
(rb_remote_proxy_get_playing_uri), (rb_remote_proxy_get_song_info),
(rb_remote_proxy_set_rating), (rb_remote_proxy_jump_next),
(rb_remote_proxy_jump_previous), (rb_remote_proxy_quit),
(rb_remote_proxy_toggle_mute),
(rb_remote_proxy_find_player_property),
(rb_remote_proxy_player_notify_handler),
(rb_remote_proxy_set_player_property),
(rb_remote_proxy_get_player_property),
(rb_remote_proxy_get_playing_source):
* remote/rb-remote-proxy.h:
* shell/Makefile.am:
* shell/main.c: (main), (handle_cmdline):
* shell/rb-shell-player.c: (rb_shell_player_class_init),
(rb_shell_player_init), (rb_shell_player_set_property),
(rb_shell_player_get_property),
(rb_shell_player_set_playing_entry), (rb_shell_player_cmd_play),
(rb_shell_player_playpause_button), (rb_shell_player_playpause),
(rb_shell_player_cmd_pause), (rb_shell_player_toggle_mute),
(rb_shell_player_seek), (filter_mmkeys):
* shell/rb-shell-player.h:
* shell/rb-shell.c: (rb_shell_remote_proxy_init),
(rb_shell_construct), (source_activated_cb),
(rb_shell_db_error_cb), (rb_shell_db_entry_added_cb),
(rb_shell_playing_entry_changed_cb), (tray_destroy_cb),
(rb_shell_load_uri_impl), (rb_shell_select_uri_impl),
(rb_shell_play_uri_impl), (rb_shell_grab_focus_impl),
(rb_shell_get_visibility_impl), (rb_shell_set_visibility_impl),
(rb_shell_get_shuffle_impl), (rb_shell_set_shuffle_impl),
(rb_shell_get_repeat_impl), (rb_shell_set_repeat_impl),
(rb_shell_play_impl), (rb_shell_pause_impl),
(rb_shell_playing_impl), (rb_shell_get_playing_time_impl),
(rb_shell_set_playing_time_impl), (rb_shell_get_playing_uri_impl),
(rb_shell_get_song_info_impl), (rb_shell_jump_next_impl),
(rb_shell_jump_previous_impl), (rb_shell_remote_quit_impl),
(rb_shell_find_player_property_impl),
(rb_shell_player_notify_handler_impl),
(rb_shell_set_player_property_impl),
(rb_shell_get_player_property_impl),
(rb_shell_get_playing_source_impl), (rb_shell_seek_impl),
(rb_shell_set_rating_impl), (rb_shell_toggle_mute_impl):
* shell/rb-statusbar.c: (rb_statusbar_shell_play_order_changed_cb):
* shell/rb-tray-icon.c: (rb_tray_icon_class_init),
(rb_tray_icon_init), (rb_tray_icon_constructor),
(rb_tray_icon_sync_action), (rb_tray_icon_set_property),
(rb_tray_icon_get_property), (rb_tray_icon_new),
(rb_tray_icon_button_press_event_cb), (rb_tray_icon_drop_cb),
(rb_tray_icon_show_window_changed_cb):
* shell/rb-tray-icon.h:
Huge patch from [email protected] to bring the Bonobo interface
back from the dark ages (Closes: #306384)
2005-06-18 Dennis Cranston <[email protected]>
* shell/rb-playlist-manager.c: Use header capitalization
for menu item labels.
* shell/rb-shell.c: Use header capitalization for menu
item labels and window titles.
(Closes: #308246)
2005-06-18 Theppitak Karoonboonyanan <[email protected]>
* configure.ac: Added 'th' (Thai) to ALL_LINGUAS.
2005-06-15 Bastien Nocera <[email protected]>
* configure.ac: patch from Ed Catmur <[email protected]> to
fix the use of --disable-dashboard/--enable-dashboard
(Closes: #307749)
2005-06-15 Bastien Nocera <[email protected]>
* configure.ac: patch from Ed Catmur <[email protected]> to
work-around AC_PATH_X returning an empty $x_libraries (Closes: #307748)
2005-06-14 Sebastien Bacher <[email protected]>
* remote/bonobo/Makefile.am: list the server file for the tarball.
2005-06-14 Christophe Fergeau <[email protected]>
* metadata/rb-metadata-gst.c: (rb_metadata_gst_new_decoded_pad_cb):
* rhythmdb/rhythmdb.c: (rhythmdb_process_metadata_load): fix gcc 4
(and 2.95) compilation
2005-06-14 Christophe Fergeau <[email protected]>
* metadata/rb-metadata-gst.c: (rb_metadata_init),
(rb_metadata_finalize), (rb_metadata_gst_error_cb),
(rb_metadata_gst_load_tag), (rb_metadata_gst_fakesink_handoff_cb),
(rb_metadata_gst_new_decoded_pad_cb),
(rb_metadata_gst_unknown_type_cb), (make_pipeline_element),
(rb_metadata_load):
* metadata/rb-metadata.h:
* player/rb-player-gst.c: (rb_player_class_init):
* rhythmdb/rhythmdb.c: (rhythmdb_event_free), (emit_error_idle),
(rhythmdb_process_metadata_load), (rhythmdb_execute_stat):
* shell/rb-shell-player.c: (rb_shell_player_init),
(info_available_cb): use decodebin for metadata reading instead of
spider, patch from [email protected]. If you don't have
gst-plugins 0.8.9, you may get GStreamer-Critical warnings in your
console (this is bug #169400).
2005-06-13 Christophe Fergeau <[email protected]>
* configure.ac: don't enable dbus or hal if newer (api incompatible)
versions are detected
* player/Makefile.am: attempt at fixing make dist
* rhythmdb/rhythmdb-gda.c:
* rhythmdb/rhythmdb-gda.h: added missing files (maybe libgda support
should just be killed?)
2005-06-12 Bastien Nocera <[email protected]>
* widgets/Makefile.am:
* widgets/rb-ellipsizing-label.c:
* widgets/rb-ellipsizing-label.h:
* widgets/rb-header.c: (rb_header_init), (rb_header_sync):
* widgets/rb-song-info.c: Patch from Paolo Borelli
<[email protected]> to remove the RBEllipsizing label, and use
GTK+'s instead (Closes: #307386)
2005-06-12 Christophe Fergeau <[email protected]>
* rhythmdb/rhythmdb.h:
* widgets/rb-property-view.c: (query_model_cb),
(rb_property_view_drag_data_get), (rb_property_view_constructor):
committ patch from Gabriel de Perthuis to add a text/uri-list target
when dragging an artist/album/genre. This allows dragging a whole
album/artist/genre to a playlist or to the desktop. Fixes #165583
2005-06-12 Christophe Fergeau <[email protected]>
* shell/rb-playlist-manager.c:
(rb_playlist_manager_save_thread_main),
(rb_playlist_manager_save_playlists):
* sources/rb-playlist-source.c: (rb_playlist_source_class_init),
(rb_playlist_source_get_property),
(rb_playlist_source_entry_added_cb),
(rb_playlist_source_add_location),
(rb_playlist_source_remove_location),
(rb_playlist_source_save_to_xml): fixes to playlist saving, fixes bug
#166340, patch from [email protected]
2005-06-12 Christophe Fergeau <[email protected]>
* sources/rb-ipod-source.c: (rb_ipod_get_itunesdb_path),
(rb_ipod_is_volume_ipod): added some sanity checks which can avoid
crashes in some cases
2005-06-12 Christophe Fergeau <[email protected]>
* data/ui/rhythmbox-ui.xml: add Quit menu item to the tray icon
2005-06-12 Christophe Fergeau <[email protected]>
* lib/rb-util.c: (rb_is_main_thread), (rb_threads_init):
* lib/rb-util.h:
* rhythmdb/rhythmdb.c: (rhythmdb_event_free), (rhythmdb_shutdown),
(rhythmdb_read_enter), (rhythmdb_read_leave),
(timeout_rhythmdb_commit), (set_metadata_string_default_unknown),
(set_props_from_metadata), (rhythmdb_process_stat_event),
(rhythmdb_process_metadata_load),
(rhythmdb_process_queued_entry_set_event),
(rhythmdb_process_events), (action_thread_main),
(rhythmdb_entry_sync), (rhythmdb_entry_set_internal),
(rhythmdb_entry_queue_set), (rhythmdb_entry_set),
(rhythmdb_prop_get_type), (entry_volume_mounted_or_unmounted),
(rhythmdb_entry_set_mount_point), (rhythmdb_entry_set_visibility):
* rhythmdb/rhythmdb.h:
* shell/main.c: (main):
* sources/rb-source.c: (rb_source_update_play_statistics):
* widgets/rb-entry-view.c: (rb_entry_view_rated_cb): reimplement
rhythmdb_entry_queue_set, this should fix some crashes when doing
a rhythmdb_entry_set while the db is read-only
2005-06-12 Christophe Fergeau <[email protected]>
* configure.ac: check for playbin, and remove the check for all other
elements
2005-06-12 Christophe Fergeau <[email protected]>
* widgets/rb-tree-view.c: (rb_tree_view_new):
* widgets/rb-tree-view.h: remove dead code
2005-06-12 Christophe Fergeau <[email protected]>
* widgets/rb-entry-view.c: (type_ahead_search_func),
(rb_entry_view_play_count_cell_data_func),
(rb_entry_view_constructor), (rb_entry_view_poll_model):
* widgets/rb-property-view.c: (rb_property_view_constructor):
* widgets/rb-tree-view.c: (rb_tree_view_new): enable type ahead find
in the various treeviews in the main UI.
2005-06-12 Christophe Fergeau <[email protected]>
* player/rb-player-gst.c: (rb_player_class_init), (rb_player_init),
(rb_player_finalize), (rb_player_gst_free_playbin),
(rb_player_construct), (rb_player_sync_pipeline), (rb_player_open),
(rb_player_close), (rb_player_play), (rb_player_pause),
(rb_player_set_replaygain), (rb_player_set_volume),
(rb_player_seekable), (rb_player_set_time), (rb_player_get_time):
* shell/rb-shell-player.c: (rb_shell_player_class_init),
(rb_shell_player_init), (rb_shell_player_get_property),
(rb_shell_player_open_location),
(rb_shell_player_set_playing_source_internal),
(rb_shell_player_error), (tick_cb):
* shell/rb-statusbar.c: (rb_statusbar_construct),
(rb_statusbar_sync_status):
* sources/rb-iradio-source.c: (rb_iradio_source_class_init):
* sources/rb-source.c: (rb_source_class_init),
(rb_source_have_url):
* sources/rb-source.h: use playbin instead of making up our own
pipeline
2005-06-12 Christophe Fergeau <[email protected]>
* player/Makefile.am: make the recorder marshallers conditionnally
compiled too.
2005-06-12 Christophe Fergeau <[email protected]>
* COPYING:
* configure.ac:
* player/Makefile.am:
* shell/Makefile.am:
* shell/rb-playlist-manager.c: (rb_playlist_manager_set_property):
* shell/rb-shell.c: (rb_shell_construct):
* sources/Makefile.am:
* sources/rb-iradio-source.c:
(stations_view_drag_data_received_cb):
* sources/rb-playlist-source.c: (rb_playlist_source_burn_playlist):
Patch from [email protected] to make compilation of the cd
burning code optional. Disable the code if libnautilus-burn is older
or newer than 2.9 or 2.10.
2005-06-11 Bastien Nocera <[email protected]>
* rhythmdb/rhythmdb-tree.c: (split_query_by_disjunctions):
* widgets/rb-query-creator.c: (rb_query_creator_load_query): Patch from
James Livingston <[email protected]> to avoid asserts if a query has
no criteria
2005-06-11 Bastien Nocera <[email protected]>
* rhythmdb/rhythmdb-tree.c: (evaluate_conjunctive_subquery):
* rhythmdb/rhythmdb.c: (rhythmdb_query_get_type):
* widgets/rb-query-creator.c: Patch from James Livingston
<[email protected]> to change the "less than" and "more than" queries to
"at most" and "at least"
2005-06-11 Bastien Nocera <[email protected]>
* widgets/rb-query-creator.c: (rb_query_creator_get_query):
Patch from James Livingston <[email protected]> to not ignore empty query
criteria (Closes: #154280)
2005-06-11 Bastien Nocera <[email protected]>
* data/glade/create-playlist.glade:
* widgets/rb-query-creator.c: (rb_query_creator_constructor),
(append_row): Patch from James Livingston <[email protected]> to allow
removing any item in the query dialog not just the all of them but
the last one (Closes: #154279)
2005-06-11 Bastien Nocera <[email protected]>
* rhythmdb/rhythmdb-query-model.c:
(rhythmdb_query_model_entry_added_cb),
(rhythmdb_query_model_add_entries),
(rhythmdb_query_model_do_insert): Patch from James Livingston
<[email protected]> to fix problems when an automatic playlist has
limits and uses sorting
2005-06-11 Bastien Nocera <[email protected]>
* shell/rb-shell.c: (rb_shell_shutdown): hide the main window
and tray icon as soon as we're going to shutdown (Closes: #171863)
2005-06-11 Bastien Nocera <[email protected]>
* shell/main.c: (main):
* shell/rb-shell.c: (rb_shell_cmd_about): remove dead codepaths
relative to monkey-media
2005-06-11 Bastien Nocera <[email protected]>
* lib/rb-file-helpers.c: (rb_uri_resolve_symlink): patch from
Paolo Borelli <[email protected]> to follow more than one level of
symlinks (Closes: #163517)
2005-06-11 Bastien Nocera <[email protected]>
* shell/rb-playlist-manager.c:
(rb_playlist_manager_save_thread_main): Patch from Loïc Minier
<[email protected]> to avoid overwriting the existing library
if saving the temporary library failed (Closes: #304519)
2005-06-11 Bastien Nocera <[email protected]>
* shell/rb-statusbar.c: (rb_statusbar_init),
(rb_statusbar_sync_status): Patch from Paolo Bacchilega
<[email protected]> to hide the progress bar when there is
no activity, and left justify the playlist duration (Closes: #153645)
2005-06-11 Bastien Nocera <[email protected]>
* rhythmdb/rhythmdb.c: (rhythmdb_compute_status_normal): patch from
James Livingston <[email protected]> to avoid mentioning hours or
minutes if they're '0' (Closes: #157341)
2005-06-11 Bastien Nocera <[email protected]>
* data/ui/rhythmbox-ui.xml:
* shell/rb-playlist-manager.c:
(rb_playlist_manager_cmd_edit_automatic_playlist),
(rb_playlist_manager_cmd_rename_playlist):
* sources/rb-sourcelist.c: (rb_sourcelist_edit_source_name),
(rb_sourcelist_title_cell_data_func), (source_name_edited_cb):
Patch from Michael Terry <[email protected]> to use the context menu
to rename playlists (Closes: #133845)
2005-06-11 Bastien Nocera <[email protected]>
* player/rb-recorder-gst.c: (rb_recorder_burn): Who didn't test the
build?
2005-06-11 Bastien Nocera <[email protected]>
* player/rb-recorder-gst.c: (rb_recorder_burn):
* sources/rb-playlist-source-recorder.c:
(rb_playlist_source_recorder_start):
* widgets/rb-header.c: (info_url): Build fixes for 64-bit systems,
partial fixes from James Henstridge <[email protected]>
(Closes: #168727)
2005-06-08 Bastien Nocera <[email protected]>
* library/.cvsignore: removed
* player/Makefile.am: cleanup
* rhythmdb/rhythmdb.c: (action_thread_main),
(rhythmdb_save_thread_main), (query_thread_main),
(rhythmdb_do_full_query_async_parsed):
send a RHYTHMDB_EVENT_DB_SAVED event even if we don't have to save
the database, otherwise the read counter doesn't get decreased
* widgets/gst-hig-dialog.c: removed
* widgets/gst-hig-dialog.h: removed
* widgets/rb-query-creator.c: added beginning of a support for
filtering by Path
2005-06-07 Bastien Nocera <[email protected]>
* shell/rb-shell.c: (rb_shell_sync_window_state): Patch from
[email protected] to work-around problems with some unforgiving
window managers while switching to the small mode
2005-06-07 Bastien Nocera <[email protected]>
* shell/rb-tray-icon.c: (rb_tray_icon_button_press_event_cb): Patch
from [email protected] to have the tray icon popup menu show
up on the right screen
2005-06-07 Bastien Nocera <[email protected]>
* sources/rb-iradio-source.c: (rb_iradio_source_add_station): Patch
from [email protected] to make the default iRadio genre
"Unknown" and not an empty string
2005-06-07 Bastien Nocera <[email protected]>
* sources/rb-sourcelist.c: (rb_sourcelist_init): Patch from
[email protected] to make the "Playing" icon right aligned
in the sources list
2005-06-07 Bastien Nocera <[email protected]>
* iradio/rb-station-properties-dialog.c:
(rb_station_properties_dialog_update_rating): Patch from
[email protected] to set the rating correctly in the radio
station properties dialog
2005-06-07 Bastien Nocera <[email protected]>
* shell/rb-playlist-manager.c:
(rb_playlist_manager_cmd_load_playlist),
(rb_playlist_manager_cmd_save_playlist):
* shell/rb-shell-player.c: (rb_shell_player_error):
* shell/rb-shell.c: (rb_shell_cmd_add_folder_to_library),
(rb_shell_cmd_add_file_to_library):
* widgets/rb-dialog.c: (rb_file_chooser_new):