Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added better coloring for strand matches #1716

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

nathandunn
Copy link
Contributor

Fixes #412

@childers If you have a chance to look at this and let us know if similar matches for .cigarE / .cigar? would be helpful.

This is a pretty simple fix. You can also issue a separate PR / patch.

@deepakunni3 I think this is ready for review. Not sure what the history of why this wasn't done in the first place (in WA1) as it was pretty easy.

@nathandunn nathandunn added this to the 2.0.7 milestone Jul 28, 2017
@nathandunn nathandunn self-assigned this Jul 28, 2017
@ghost ghost added the in progress label Jul 28, 2017
@nathandunn
Copy link
Contributor Author

BWT, does this fix #1044 as well?

I wanted this fix for #1619 (to check errors).

@nathandunn
Copy link
Contributor Author

screen shot 2017-07-28 at 9 47 10 am

screen shot 2017-07-28 at 9 42 52 am

@deepakunni3
Copy link
Member

@nathandunn It would be awesome if the color of the reads matched JBrowse/Alignment track.

Here is an image that shows the comparison of WebApollo/DraggableAlignments vs JBrowse/Alignment:
screen shot 2017-07-28 at 1 20 35 pm

color for forward strand aligned reads - #EC8B8B
color reverse strand aligned reads - #898FD8

Also, the span between two paired end reads should be a lighter shade,
screen shot 2017-07-28 at 1 46 17 pm

@nathandunn
Copy link
Contributor Author

Okay. I added a better coloring scheme. Though the colors listed I believe were for non-matches:

JBrowse:
screen shot 2017-07-28 at 1 30 49 pm

New Apollo color schemas:
screen shot 2017-07-28 at 1 30 46 pm

@nathandunn nathandunn merged commit ec88d5e into GMOD:master Jul 28, 2017
@ghost ghost removed the in progress label Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants