Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding engine forks and whatnot #44

Closed
doggogit opened this issue Jan 25, 2023 · 14 comments
Closed

Regarding engine forks and whatnot #44

doggogit opened this issue Jan 25, 2023 · 14 comments

Comments

@doggogit
Copy link
Contributor

Alright, I believe we should be a little harsh when it comes to engine forks.

Any engine forks that include not that many QoL changes, have miscellaneous changes (like a new HUD) that can be made with a script within 5 to 10 minutes, should be automatically rejected.

There are, obviously, exception, for example: the Raltyro Psych Fork, Pluma's Psych Fork and others that I can't think of at the top of my head.

(feel free to pin this btw)

@doggogit doggogit changed the title Regarding Engine forks and whatnot Regarding engine forks and whatnot Jan 25, 2023
@BombasticTom
Copy link
Contributor

BombasticTom commented Jan 25, 2023

Custom Psych Engine too!!

(this is a joke, it doesn't have any progress cuz i've stopped working on it months ago)

@ninjamuffin99
Copy link
Member

more or less i think. if someone looks at the changes, and they dont think they are super incredible awesome or interesting , can be rejected

@Burgerballs
Copy link
Contributor

Most of the stuff they add (specifically psych forks) are already replicated in lua by the base Psych community too.

@BombasticTom
Copy link
Contributor

damn, didn't know that. the only fork i know of (os engine) changes some menu stuff and adds new options (that i personally think are too much)

@Burgerballs
Copy link
Contributor

damn, didn't know that. the only fork i know of (os engine) changes some menu stuff and adds new options (that i personally think are too much)

I checked the os engine readme and yeah all of the OS Engine features (other than the menus) can be recreated in base Psych 0.6.3, including shaders lol

@BombasticTom
Copy link
Contributor

There's a lot of psych ports just using lua scripts (lmao)

@Burgerballs
Copy link
Contributor

There's a lot of psych ports just using lua scripts (lmao)

Most of them aren't theirs either too

@doggogit
Copy link
Contributor Author

more or less i think. if someone looks at the changes, and they dont think they are super incredible awesome or interesting , can be rejected

I feel like a section related to this should be added to the Code of Conduct file

@Burgerballs
Copy link
Contributor

more or less i think. if someone looks at the changes, and they dont think they are super incredible awesome or interesting , can be rejected

I feel like a section related to this should be added to the Code of Conduct file

https://github.com/sindresorhus/awesome/blob/main/awesome.md
"Research if the stuff you're including is actually awesome."

@doggogit
Copy link
Contributor Author

more or less i think. if someone looks at the changes, and they dont think they are super incredible awesome or interesting , can be rejected

I feel like a section related to this should be added to the Code of Conduct file

https://github.com/sindresorhus/awesome/blob/main/awesome.md "Research if the stuff you're including is actually awesome."

Only a suggestion, but fair enough, should've probably read the manifesto and stuff lol

@doggogit
Copy link
Contributor Author

Should this issue be closed? I don't really know where to take this discussion from here, this was just for raising awareness, not gonna lie. It can be a pinned issue if possible.

@BombasticTom
Copy link
Contributor

i think that the pinned issue should be the first one made (the Add Descriptions To Links? one)

@BombasticTom
Copy link
Contributor

oh well lol

@doggogit
Copy link
Contributor Author

Closing this as #51 resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants