{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":539825753,"defaultBranch":"main","name":"nu_scripts","ownerLogin":"FrancescElies","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-09-22T06:10:33.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6558089?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1663865181.6375349","currentOid":""},"activityList":{"items":[{"before":"7ba3b00bb50ce07a83136992760057f14c027f47","after":"9a12d8df3923efd5669dddf3bddc1931cc844bb6","ref":"refs/heads/main","pushedAt":"2024-07-30T09:28:25.000Z","pushType":"push","commitsCount":554,"pusher":{"login":"FrancescElies","name":"Francesc Elies","path":"/FrancescElies","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6558089?s=80&v=4"},"commit":{"message":"Additional Theme Features (#925)\n\nChanges to `make.nu`:\r\n\r\n* Adds in missing shapes and types noted further down in this PR by\r\n@fdncred\r\n* Adds colors for types - Mostly matching the corresponding shape, but\r\nwith any attribute (e.g., bold) removed\r\n* Changed `int` and `float` values to be distinct. In most themes, the\r\ncolors should be complementary.\r\n* Changes `bool: false` and `hints` colors - They were hardcoded to\r\n`dark_grey` and wouldn't show up on some themes. Now uses a theme color\r\nthat should correspond to a theme-appropriate grey in most cases.\r\n* Alphabetizes shapes and types so that Previews are also sorted\r\nproperly\r\n* Eliminated spurious newline when sourcing theme (from printing OSC\r\ncodes for terminal colors)\r\n* Renamed `3024` theme to `3024r` since module names can't be an `int`\r\n\r\nChanges to `theme preview small`:\r\n\r\n* Remove extra vertical spacing that was caused by different-sized row\r\ncolumn content\r\n* Logically group elements - Types, Conditionally computed (closures)\r\ntypes, Shapes, and other Structure (e.g., header, row_index, foreground,\r\netc.)\r\n* Displays foreground/background on one line for clarity\r\n\r\nResult is a much more compact, but also more readable, table.\r\n\r\nComparison:\r\n\r\n<details><summary>Before</summary>\r\n<p>\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/2673855d-d20d-4e14-8029-255138f2ecc9\"\r\n/>\r\n</p>\r\n</details> \r\n\r\n<details><summary>After</summary>\r\n<p>\r\n<img\r\nsrc=\"https://github.com/user-attachments/assets/c8824b7a-440d-4567-bd69-b2e1df358340\"\r\n/>\r\n</p>\r\n</details> \r\n\r\n* Also refactored a lot of the code to be more maintainable - Moves the\r\nrendering off to separate functions.\r\n\r\nChanges to `preview_generate_screenshots.nu`:\r\n\r\n* Accepts the method for generating screenshots as an argument\r\n* Additional generation method using asciinema, agg (asciinema to\r\nanimated gif), and ffmpeg (to convert the animated gif to a single-image\r\nPNG)\r\n\r\nAdditional Notes:\r\n\r\n- Some Lemnos themes use color values that are the same (or nearly the\r\nsame) as the background in places. These are \"broken\" themes and always\r\nhave been as some elements will simply not be visible.\r\n\r\n- There's a longstanding (I believe) bug that special-cased `record` for\r\nthe *key* rather than the *value*. I've fixed it so that the *key* is\r\nnow handled properly (same as other types), but I haven't implemented\r\nany changes for color values that use a record (e.g., `{ fg: \"#80a1a1\",\r\nattr: \"b\" }`) as this would make the table less compact. I'll look at\r\ndoing this for the longer form `preview theme` later.\r\n\r\n- Closures other than for `string`, `bool`, `date`, and `filesize` are\r\ncurrently only displayed as a summary. There aren't any themes currently\r\nthat this impacts, but if you create one manually, the display results\r\nwere pretty bad. This is primarily due to bad indentation from\r\n`config.nu` (and/or defaults). A proper `nu-indent` would help fix this,\r\nor maybe we could just remove all whitespace and display any closure as\r\na one-liner.\r\n\r\nI probably won't regenerate screenshots until we figure out what to do\r\nabout the \"monotone\" type colors.","shortMessageHtmlLink":"Additional Theme Features (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2434410364\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nu_scripts/issues/925\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nu_scripts/pull/925/hovercard\" href=\"https://github.com/nushell/nu_scripts/pull/925\">nushell#925</a>)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEjMnjOQA","startCursor":null,"endCursor":null}},"title":"Activity · FrancescElies/nu_scripts"}