Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show status Finishing when appropriate #34

Closed
kbernhagen opened this issue Feb 21, 2022 · 2 comments · Fixed by #37
Closed

Show status Finishing when appropriate #34

kbernhagen opened this issue Feb 21, 2022 · 2 comments · Fixed by #37

Comments

@kbernhagen
Copy link
Contributor

Currently, when I click Pause > Finish, the WU continues to show status Running, even though the client log shows it was correctly set to finish.
@kbernhagen kbernhagen mentioned this issue Feb 21, 2022
Closed
@kbernhagen
Copy link
Contributor Author

See PR #35

@kbernhagen
Copy link
Contributor Author

kbernhagen commented Feb 22, 2022 •
edited
Loading

FINISH is a pseudo-state that is only appropriate to show as a substitute for RUN.
NOT every time config.value.finish is true.

eg

    if(config.value.finish && state == "RUN") return status["FINISH"]

I only put "FINISH" in the status table because it looked like a better place for possible future language localization.

@shreyashah1903 shreyashah1903 mentioned this issue Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with Config page. shreyashah1903/fah-web-client-bastet-1
1 participant
@kbernhagen