Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Signing FAH executable before building Windows installer #62

Open
Hou5e opened this issue Dec 22, 2022 · 2 comments
Open

Code Signing FAH executable before building Windows installer #62

Hou5e opened this issue Dec 22, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Hou5e
Copy link
Contributor

Hou5e commented Dec 22, 2022

Enhancement: All the executable files distributed in the installer should be signed with the code-signing certificate as part of the build process for Windows.

This will prevent Anti-virus & Anti-malware software from potentially flagging the executable files as malicious. It also allows the programs to be verified by the user for not having been modified or tampered with.
(copy from: FoldingAtHome/fah-client-win-installer#16)

@Hou5e
Copy link
Contributor Author

Hou5e commented Dec 22, 2022

I excluded v8 FAH Client's path from Avira anti-virus after the first few installs of v8.1.3, when it started to trigger the AV (PUA threat heuristic). I'm not sure how common that will be for other people.

@Hou5e Hou5e changed the title Code Signing executable FAH programs before building installer Code Signing FAH executable before building Windows installer Dec 22, 2022
@jcoffland jcoffland added the enhancement New feature or request label Jan 4, 2023
@hc970
Copy link

hc970 commented May 6, 2023

Enhancement: All the executable files distributed in the installer should be signed with the code-signing certificate as part of the build process for Windows.

This will prevent Anti-virus & Anti-malware software from potentially flagging the executable files as malicious. It also allows the programs to be verified by the user for not having been modified or tampered with. (copy from: FoldingAtHome/fah-client-win-installer#16)

Agreed. I would almost go as far as stating this as an essential requirement now. I recently installed a piece of paid for software and it wasn't signed. The installer was initially blocked. Once installed Windows Defender on Windows 11 blocked its use and quarantined the now installed files. They weren't malware just unsigned, very new and not often used.

Another AV vendor on my other system did likewise for the same software. I had to un-quarantine the software and make exceptions for it on both systems to resolve the issue. A non-technical user would not be able to use the software in this case.

Please also consider meeting the stricter Authenticode guidelines set by Microsoft:

https://msrc.microsoft.com/update-guide/vulnerability/CVE-2013-3900

https://learn.microsoft.com/en-us/security/trusted-root/program-requirements

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants