Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow: Have/normalize to-string API for all objects. #86

Open
ygoldfeld opened this issue Mar 11, 2024 · 0 comments
Open

flow: Have/normalize to-string API for all objects. #86

ygoldfeld opened this issue Mar 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ygoldfeld
Copy link
Contributor

Not-unrelated to #71 and Flow-IPC/ipc#85 -- probably should be looked-at at the same time:

Flow-IPC (generally speaking, written after Flow, except for some parts that were written in parallel) is pretty good about this (possibly outside non-ipc::session::shm SHM-jemalloc-land, but that's orthogonal), but Flow might be less so, or less consistently so:

Have a to-string output for all object types. So far we've been using ostream<< for this. (Maybe also look into how fmt deals with this, as it might be relevant for #78 -- does it performantly and nicely play with to-string APIs written as ostream<< impls?)

The formatting/order/style/whatever should follow some consistent convention; and since we share DNA with Flow-IPC should be consistent with Flow-IPC/ipc#85 work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant