Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow.log: Add built-in token sanitizing (for security/safety). #65

Open
ygoldfeld opened this issue Mar 9, 2024 · 0 comments
Open

flow.log: Add built-in token sanitizing (for security/safety). #65

ygoldfeld opened this issue Mar 9, 2024 · 0 comments
Labels
enhancement New feature or request from-akamai-pre-open Issue origin is Akamai, before opening source

Comments

@ygoldfeld
Copy link
Contributor

ygoldfeld commented Mar 9, 2024

@ygoldfeld filed pre-open-source:

Something like -

  • Msg_metadata take optional map of search/replace pairs, each one being string (to replace), String_view (to replace-with). And/or a filter function. Just make it elegant yet highly performant.
  • Add some way to make it easy to invoke via FLOW_LOG_() API.
  • Note usually the map is known at the log call site only, not at process startup or whatever. E.g., in (a certain server), it needed to replace a particular ConnectionID with "(redacted)" + same thing with potential hex version of that value.
  • Have the replacement be done in a performant way at the last second probably by Ostream_log_msg_writer, while writing to final output ostream. Don't create a new copy of the string with everything replaced. (Recall, though, Logger is technically free to not use Ostream_log_msg_writer, so it just needs to be in Logger's formal contract to respect the filtering functionality.)

Priority that I know of: Nothing pressing at the moment at least. Came about due to some manual redacting like this that had to be done elsewhere.

@ygoldfeld ygoldfeld added enhancement New feature or request from-akamai-pre-open Issue origin is Akamai, before opening source labels Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request from-akamai-pre-open Issue origin is Akamai, before opening source
Projects
None yet
Development

No branches or pull requests

1 participant