Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FhirClient: handle prefer operation outcome in resource response #1690

Conversation

mmsmits
Copy link
Member

@mmsmits mmsmits commented Apr 16, 2021

fixes: #1681

Copy link
Member

@marcovisserFurore marcovisserFurore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small unittest change

@@ -87,7 +87,7 @@ private static void CreateItems()
Family = "Donald",
}
},
Id = "pat1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better approach to make the identifiers dependent on the FhirVersion, like for example:

"pat1" + ModelInfo.Version

Make this a variable and use them in the tests.

Copy link
Member

@marcovisserFurore marcovisserFurore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !

@marcovisserFurore marcovisserFurore merged commit f71543e into develop-stu3 Apr 22, 2021
@marcovisserFurore marcovisserFurore deleted the bugfix/1681-client-handle-prefer-operation-outcome-resource-in-response branch April 22, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle OperationOutCome resource in response
2 participants