Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value systems from Code system https://terminology.hl7.org/5.5.0/CodeSystem-hl7TermMaintInfra.json.html are not expanded correctly #2792

Closed
aswathikrishnan24 opened this issue May 28, 2024 · 2 comments · Fixed by #2825
Assignees
Labels

Comments

@aswathikrishnan24
Copy link

aswathikrishnan24 commented May 28, 2024

Describe the bug

The Value sets :
356 http:https://terminology.hl7.org/ValueSet/mif-conceptRelationshipKind
357 http:https://terminology.hl7.org/ValueSet/mif-conceptRelationshipReflexivity
358 http:https://terminology.hl7.org/ValueSet/mif-conceptRelationshipSymmetry
359 http:https://terminology.hl7.org/ValueSet/mif-conceptRelationshipTransitivity

Belonging to Code system : https://terminology.hl7.org/5.5.0/CodeSystem-hl7TermMaintInfra.json.html are not expanded.

image

Value set expansion of http:https://terminology.hl7.org/ValueSet/mif-conceptRelationshipTransitivity (value set 359) should pick all codes under "MIF-ConceptRelationshipTransitivity" and then exclude itself which is MIF-ConceptRelationshipTransitivity .

All codes :

  1. MIF-ConceptRelationshipTransitivity
  2. transitive
  3. antitransitive

The expanded codes should be

  1. transitive
  2. antitransitive

In the Codes table, the corresponding codes are not present.
Value set IDs 356 - 359 have no codes

To Reproduce
Steps to reproduce the behavior:

  1. Install firely-car tool
  2. Generate car file from us core 5.0.1 package.
{
    "name": "Us-core-test-5.0.1",
    "version": "0.1.0",
    "description": "describe your package",
    "author": "supply your name here",
    "dependencies": {
      "hl7.fhir.us.core": "^5.0.1"
    }
  }
  1. Verify the Value set 359 from Value set table
  2. Verify if the codes are generated in Codes table

Expected behavior
The expanded codes should be

  1. transitive
  2. antitransitive

Version used:

  • FHIR Version: R4
  • Version: Firely-car tool 2.1.2
@mmsmits
Copy link
Member

mmsmits commented May 29, 2024

Looking at this, we seem to throw away the children of the codes when we throw away the parent.

Todo:

  • When we delete a code, check for children
  • If children, then put them on the level of the code you want to delete and delete the original code.

@aswathikrishnan24
Copy link
Author

307 http:https://hl7.org/fhir/ValueSet/encounter-participant-type also seems to expand incorrectly because of the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants