Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the values of ObjectValue with those of ITypedElement. #2544

Open
ewoutkramer opened this issue Jul 19, 2023 · 1 comment
Open

Align the values of ObjectValue with those of ITypedElement. #2544

ewoutkramer opened this issue Jul 19, 2023 · 1 comment
Labels
breaking change This issue/commit causes a breaking change, and requires a major version upgrade enhancement

Comments

@ewoutkramer
Copy link
Member

After having worked on the performance of FhirDateTime etc. I now realize that the ObjectValue for these types should be the System types DateTime, Date and Time. This means:

  • The parsers will validate the format, and store the parsed system type in ObjectValue. Like with the other types the parser will put a string here if it fails to parse the datetime
  • We will no longer have a random string in ObjectValue, so the constructor taking a string should be obsoleted and replaced with an explicit Parse() function.
  • Value will change to be a DateTime/Time/Date as well.

This is obviously a breaking change, Is it too big?

@ewoutkramer ewoutkramer added enhancement breaking change This issue/commit causes a breaking change, and requires a major version upgrade labels Jul 19, 2023
@ewoutkramer
Copy link
Member Author

In any case, the parser should validate this, otherwise this value will fall "between the cracks" of the parser and profile validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This issue/commit causes a breaking change, and requires a major version upgrade enhancement
Projects
None yet
Development

No branches or pull requests

2 participants